Skip to content

Conversation

@mythi
Copy link
Contributor

@mythi mythi commented Nov 20, 2024

As of Go 1.21, toolchain versions must use the 1.N.P syntax.

Moreover, since Go 1.21 is no longer maintained, bump to Go 1.22 with the new syntax.

@mythi mythi requested a review from a team as a code owner November 20, 2024 11:59
Copy link
Member

@lmilleri lmilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

Copy link
Member

@lmilleri lmilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if the new golang version is required in other places, eg:

.github/workflows/kuttl-int-tests.yaml
Dockerfile

As of Go 1.21, toolchain versions must use the 1.N.P syntax.

Moreover, since Go 1.21 is no longer maintained, bump to Go 1.22
with the new syntax.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi mythi force-pushed the go-version-update branch from aa92a5e to c64d1d9 Compare November 27, 2024 06:03
lmilleri pushed a commit to lmilleri/trustee-operator that referenced this pull request Dec 3, 2024
…component-updates/trustee-operator

chore(deps): update trustee-operator to b813bb3
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt bpradipt requested a review from lmilleri December 4, 2024 15:54
@lmilleri lmilleri merged commit cd5909c into confidential-containers:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants