Update kbs configuration #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @bpradipt |
bpradipt
reviewed
Jan 30, 2024
| "--config", | ||
| "--config-file", | ||
| "/etc/kbs-config/kbs-config.json", | ||
| "--auth-public-key", |
Member
There was a problem hiding this comment.
So for the latest code, auth-public-key is not required ?
Member
There was a problem hiding this comment.
Ah ok, it's part of the config.. Ignore my comment
Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
force-pushed
the
lmilleri/update-config
branch
from
32ab645 to
86c20aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the KBS configuration for being compatible with the latest all-in-one KBS image.
Please note the authentication key is provided as part of the kbs-config.yaml file, not sure how to consume the secret
kbsAuthSecretName: kbs-auth-public-key