Volume and volumeMount refactoring #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@lmilleri can you create a new PR related to code refactoring? We can get that merged first and then review this one related to running trustee as non-privileged container |
lmilleri
changed the title
bpradipt
reviewed
May 20, 2024
| } | ||
|
|
||
| // RunAsUser (root) 0 | ||
| runAsUser := int64(0) |
Member
There was a problem hiding this comment.
This should be in a separate PR
Member
Author
There was a problem hiding this comment.
actually I didn't remove those lines, you can find them at line 424
bpradipt
reviewed
May 20, 2024
Added volumes.go Signed-off-by: Leonardo Milleri <[email protected]>
First create all the volumes and then decide which container should mount it as volumeMount. The code should be more readable and flexible. Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
pushed a commit
to lmilleri/trustee-operator
that referenced
this pull request
Jul 26, 2024
…references/main chore(deps): update konflux references to f951900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code should be more readable and flexible.