RVPS reference values provided via K8s configmap #11
Conversation
This configuration applies when the json storage backend is chosen Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
force-pushed
the
rvps-json
branch
2 times, most recently
from
68da290 to
fac2450
Compare
Signed-off-by: Leonardo Milleri <[email protected]>
| # literals: | ||
| # - key1=res1val1 | ||
| # - key2=res1val2 | ||
|
|
There was a problem hiding this comment.
Can you try adding a patch.yaml like
apiVersion: confidentialcontainers.org/v1alpha1
kind: KbsConfig
metadata:
name: kbsconfig-sample
spec:
kbsSecretResources:
- "kbsres1"
and include it in kustomization.yaml like
[snip]
secretGenerator:
- name: kbs-auth-public-key
files:
- kbs.pem
#- name: kbsres1
# literals:
# - key1=res1val1
# - key2=res1val2
#patches:
#- patch.yaml
resources:
- kbsconfig_sample.yaml
[snip]
So when you uncomment the secret and the patch, and apply it the kbsconfig should have the kbsSecretResources.
We can then use this model for the optional elements like rvps values as well.
There was a problem hiding this comment.
Good point, can do for the kbs resources. Not sure about RVPS reference values though, because in case of json store backend we have to provide at least an empty json file, e.g.
[
]What if I provide the empty json by default and mention a valid json sample with pre-populated values?
There was a problem hiding this comment.
I see... then you can mention about having a valid json file in the readme and uncommenting relevant entries in kustomization to use the json file as configmap
configmapGenerator:
- name: ..
namespace: ..
files:
#- rvps-ref-values.json
The kustomization.yaml file contains the patches for injecting k8s secrets and RVPS reference values. The former are commented out by default, the latter are enabled by default because RVPS needs at least an empty json configuration file. Signed-off-by: Leonardo Milleri <[email protected]>
bpradipt
left a comment
bpradipt
left a comment
There was a problem hiding this comment.
lgtm
Didn't test it though...
…references/main chore(deps): update konflux references
2 participants
This configuration applies when the json storage backend is chosen