-
Notifications
You must be signed in to change notification settings - Fork 26
Alignment to trustee v0.15.0 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment to trustee v0.15.0 #104
Conversation
3271c3d to
a6825e0
Compare
|
@fitzthum @bpradipt PTAL, in particular the policy changes introduced for trustee v0.15.0 |
fitzthum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes about the resource policy.
You might want to check out how the built-in affirming policy has changed in Trustee. It now checks every submod rather than just cpu or cpu0
| allow { | ||
| input["submods"]["cpu"]["ear.status"] != "contraindicated" | ||
| not input["submods"]["cpu0"]["ear.veraison.annotated-evidence"]["sample"] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These policies mean different things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're right. Even though the policy is provided here as a sample, better to provide a better one.
What about this?
package policy
import rego.v1
default allow = false
allow if {
not any_not_affirming
count(input.submods) > 0
}
any_not_affirming if {
some _, submod in input.submods
submod["ear.status"] != "affirming"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good policy. It does still have a different meaning than the original one which simply checks if the CPU has a certain type. Actually that policy is still valid today.
Resource/attestation policy changes Attestation policy VolumeMount now includes subpath to allow writing on r/o filesystem Signed-off-by: Leonardo Milleri <[email protected]>
a6825e0 to
bb23cb7
Compare
fitzthum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem good.
Resource/attestation policy changes
Attestation policy VolumeMount now includes
subpathto allow writing on container r/o filesystem