Access env variables while initializing ApiClient #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaileshpadave
force-pushed
the
fixEnvVarIssue
branch
from
d05bddb to
ed731f4
Compare
shaileshpadave
force-pushed
the
fixEnvVarIssue
branch
from
ed731f4 to
e19de2e
Compare
shaileshpadave
force-pushed
the
fixEnvVarIssue
branch
2 times, most recently
from
ce27828 to
a8ef938
Compare
shaileshpadave
force-pushed
the
fixEnvVarIssue
branch
from
a8ef938 to
44f5c52
Compare
shaileshpadave
changed the title
jmigueprieto
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Previously, calling new ApiClient() only set the useEnvVariables flag on the builder, but the environment variables were not actually applied until build() was invoked. Now, after setting the flag, we explicitly call applyEnvVariables() to ensure the environment values are set before the client is initialised.
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered