Test to check the Datatype of Priority field in subWorkflowParams #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI build is failing. Please fix the issue. |
common/src/test/java/com/netflix/conductor/common/workflow/SubWorkflowParamsTest.java
Outdated
Show resolved
Hide resolved
jmigueprieto
suggested changes
Mar 26, 2025
There was a problem hiding this comment.
- The test is related to
WorkflowDef.TestWorkflowTaskis not the best place for it. - Name the test based on the specific checks it's doing (or the issue it's addressing). Use
@DisplayNamee.g.:@DisplayName("it should handle null values when InputParam is a List")
...sdk/conductor-client/src/test/java/com/netflix/conductor/client/worker/TestWorkflowTask.java
Outdated
Show resolved
Hide resolved
...sdk/conductor-client/src/test/java/com/netflix/conductor/client/worker/TestWorkflowTask.java
Outdated
Show resolved
Hide resolved
v1r3n
approved these changes
Mar 27, 2025
jmigueprieto
suggested changes
Mar 27, 2025
...client/src/test/java/com/netflix/conductor/client/worker/WorkflowDefDeserializationTest.java
Outdated
Show resolved
Hide resolved
...client/src/test/java/com/netflix/conductor/client/worker/WorkflowDefDeserializationTest.java
Outdated
Show resolved
Hide resolved
jmigueprieto
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Added test case for the Priority field in the SubWorkflowParams