Skip to content

Conversation

orkes-harshil
Copy link
Contributor

@orkes-harshil orkes-harshil commented Mar 25, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

This PR changes the Datatype of Priority from Integer to Object.

Issue

The Priority field in SubWorkflowParams supports variable substitution at run time and expects Object in server code. In java sdk's SubWorkflowParams POJO, priority was defined as Integer and that was creating a parsing error.

Copy link
Contributor

@jmigueprieto jmigueprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - This change was made in conductor-common already

@jmigueprieto jmigueprieto merged commit d6d8211 into main Mar 25, 2025
6 checks passed
@jmigueprieto jmigueprieto deleted the fix_subwf_priority branch March 25, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants