Skip to content

Expose payload functions publicly, to allow clients to be extended. #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lbestatlas
Copy link
Contributor

Pull Request type

  • Other (please describe): Providing ability to extend the TaskClient and WorkflowClients, as was possible in the legacy client.

Changes in this PR

#385

In the deprecated conductor-client, the WorkflowClient was not declared as final, this made it possible to extend the Client to add additional ways to retrieve Entities and make other custom calls using the ClientBase methods.

The new WorkflowClient is declared final, so only public classes/methods are available. Custom calls are still possible using ConductorClientRequest.builder(), and ConductorClient. However, there is no publicly exposed way to populate or upload Task/Workflow payloads. Even the ExternalPayloadStorage class is also not publicly exposed.

Make the following methods on the WorkflowClient public:

populateWorkflowOutput
checkAndUploadToExternalStorage
Make the following methods on the TaskClient public:

populateTaskPayloads ( note: evaluateAndUploadLargePayload already public)

Alternatives considered

Refer to #385

@jeffbulltech jeffbulltech added the enhancement New feature or request label Mar 14, 2025
@jeffbulltech jeffbulltech added the help wanted Extra attention is needed label Mar 18, 2025
@lbestatlas
Copy link
Contributor Author

@bradyyie have you had a chance to look at this? We need this feature to unblock our use of the spring client. If there are concerns with the implementation please let me know so that I can amend the PR.

@jmigueprieto jmigueprieto merged commit 9413a92 into conductor-oss:main Mar 25, 2025
2 checks passed
@jeffbulltech jeffbulltech requested a review from bradyyie March 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants