Skip to content

Add missing createdBy field to fix workflow search endpoint #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Add missing createdBy field to fix workflow search endpoint #401

merged 1 commit into from
Feb 27, 2025

Conversation

ystxn
Copy link
Contributor

@ystxn ystxn commented Feb 20, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

The createdBy field is lost when Workflow gets wrapped into WorkflowSummary, leading to null createdBy fields in the workflow search endpoint

@ystxn ystxn requested review from v1r3n and jmigueprieto February 20, 2025 08:37
jmigueprieto
jmigueprieto approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@jmigueprieto jmigueprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1r3n v1r3n merged commit 6d99063 into main Feb 27, 2025
8 checks passed
@ystxn ystxn deleted the fix/workflow-summary-created-by branch March 2, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1r3n v1r3n v1r3n approved these changes

+1 more reviewer

@jmigueprieto jmigueprieto jmigueprieto approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ystxn @v1r3n @jmigueprieto