Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/16356380375 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jul 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17136603704. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor

2025-07-17T21:50:50.2670660Z Error: `cargo metadata` exited with an error: error: failed to load manifest for workspace member `/home/conda/feedstock_root/build_artifacts/rerun-sdk_1752788894200/work/crates/build/re_build_info`
2025-07-17T21:50:50.2671357Z referenced by workspace at `/home/conda/feedstock_root/build_artifacts/rerun-sdk_1752788894200/work/Cargo.toml`
2025-07-17T21:50:50.2671719Z 
2025-07-17T21:50:50.2671931Z Caused by:
2025-07-17T21:50:50.2672222Z   failed to parse manifest at `/home/conda/feedstock_root/build_artifacts/rerun-sdk_1752788894200/work/crates/build/re_build_info/Cargo.toml`
2025-07-17T21:50:50.2672512Z 
2025-07-17T21:50:50.2672715Z Caused by:
2025-07-17T21:50:50.2672947Z   feature `edition2024` is required
2025-07-17T21:50:50.2673057Z 
2025-07-17T21:50:50.2673393Z   The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.84.0 (66221abde 2024-11-19)).
2025-07-17T21:50:50.2673705Z   Consider trying a newer version of Cargo (this may require the nightly release).
2025-07-17T21:50:50.2674187Z   See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.

@jleibs
Copy link
Contributor

jleibs commented Aug 6, 2025

This is quite perplexing:

that feature is not stabilized in this version of Cargo (1.84.0 (66221abde 2024-11-19)).

But I just checked the rust 1.85 package which should have been being used and it should have Cargo 1.85 -- so where is this error coming from? I tried bumping the build number to re-kick CI. 🤞

@jleibs
Copy link
Contributor

jleibs commented Aug 6, 2025

Oops -- I think we just needed to re-render

jleibs and others added 3 commits August 8, 2025 15:31
Leave osx non-arm alone

Bump rust compiler version to 1.85.0

[ci skip] added user ntjohnson1

Add windows ar to bat, use conda cc for mac x86, linux try to use conda clang for ring

Fix lint

Windows needs exe

One more try with flags

Name the flags correctly

More flag mangling for mac x86

Windows paths are a little different. Try unpathed option

Mac x86 more specific flags not overriding so clobber

I guess windows needs llvm compiler too

One more flags change for today

Extra space

A little confused about the order of operations for generate vs target specific flags being respected in our recipe

On mac we are just using the latest clang

Actually change the exported flags
@ntjohnson1 ntjohnson1 self-requested a review as a code owner August 15, 2025 12:45
@ntjohnson1
Copy link
Contributor

For context only llvm-ar works for psm rust-lang/stacker#128
and ring requires clang to properly build its wasm target briansmith/ring#2581. The flag configuration is a little gross here but I'm hoping we can get things resolved more generally for 0.25.0 otherwise I can be responsible for making the flag management a little nicer.

@ntjohnson1
Copy link
Contributor

@conda-forge-admin, please rerender

@ntjohnson1 ntjohnson1 added the automerge Merge the PR when CI passes label Aug 15, 2025
@traversaro
Copy link
Contributor

Just to understand, is the use of %CONDA_PREFIX% instead of %BUILD_PREFIX% intentional? Just to clarify, coda-build and rattler-build use two conda environments, the build and the host one. To avoid confusion, the usual CONDA_PREFIX env variable is not available there, but just %BUILD_PREFIX% (for the build env) and %PREFIX% (for the host env).

@ntjohnson1
Copy link
Contributor

ntjohnson1 commented Aug 21, 2025

Just to understand, is the use of %CONDA_PREFIX% instead of %BUILD_PREFIX% intentional? Just to clarify, coda-build and rattler-build use two conda environments, the build and the host one. To avoid confusion, the usual CONDA_PREFIX env variable is not available there, but just %BUILD_PREFIX% (for the build env) and %PREFIX% (for the host env).

Not strongly intentional. My understanding is that the CONDA_PREFIX was exposed before running the build script so the location was unambiguous. I had just used CONDA_PREFIX for the other flags so stuck consistent to that

Once things are unblocked I assume there will be some cleanup since all the bugs are at least clear.

@traversaro
Copy link
Contributor

Just to understand, is the use of %CONDA_PREFIX% instead of %BUILD_PREFIX% intentional? Just to clarify, coda-build and rattler-build use two conda environments, the build and the host one. To avoid confusion, the usual CONDA_PREFIX env variable is not available there, but just %BUILD_PREFIX% (for the build env) and %PREFIX% (for the host env).

Not strongly intentional. My understanding is that the CONDA_PREFIX was exposed before running the build script so the location was unambiguous. I had just used CONDA_PREFIX for the other flags so stuck consistent to that

Once things are unblocked I assume there will be some cleanup since all the bugs are at least clear.

Ah, apparently CONDA_PREFIX and BUILD_PREFIX point to the same location, I was not aware of that.

@ntjohnson1
Copy link
Contributor

Ok all the windows builds succeed but the ones that fail run out of disk space. Looking now if there is a config to control that. If you're familiar a pointer might speed things up or feel free to push directly.

@traversaro
Copy link
Contributor

Ok all the windows builds succeed but the ones that fail run out of disk space. Looking now if there is a config to control that. If you're familiar a pointer might speed things up or feel free to push directly.

Sure, unfortunately the explicit option is Linux only (see conda-forge/conda-smithy#1949), but there is another commonly used workaround that is to use the C:\ drive.

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor

Unfortunately rerendering is adding the Python 3.14 build, I guess there is some bug in conda-smithy or in the pinning.

@ntjohnson1
Copy link
Contributor

ntjohnson1 commented Aug 21, 2025

Unfortunately rerendering is adding the Python 3.14 build, I guess there is some bug in conda-smithy or in the pinning.

Thanks for fixing the storage. I have conda-smithy locally so I think I can decrease the version of that package and rerender then push. I read your issue and it looks like its the migrator that needs to get updated first

@traversaro
Copy link
Contributor

Unfortunately rerendering is adding the Python 3.14 build, I guess there is some bug in conda-smithy or in the pinning.

Thanks for fixing the storage. I have conda-smithy locally so I think I can decrease the version of that package and rerender then push. I read your issue and it looks like its the migrator that needs to get updated first

Yes, if you want to have a quick solution you can manually remove the files that end with cp314.yaml. in https://github.com/regro-cf-autotick-bot/rerun-sdk-feedstock/blob/0.24.0_hbd0829/.ci_support/, that should fix the problem until the next rerender.

@traversaro
Copy link
Contributor

My bad, actually the files that was necessary to modify were the one in .azure-pipelines, I just did that.

@ntjohnson1
Copy link
Contributor

My bad, actually the files that was necessary to modify were the one in .azure-pipelines, I just did that.

I added 3.9 back in as well. 🤞

@ntjohnson1
Copy link
Contributor

Summary

  • Needed to add AR flags for cross platform because of stacker
  • Needed a whole mess of CFLAGS because of ring
    • The nix build included similar approach
  • @traversaro added a new build dir for windows to avoid out of disk space
  • Hacked together some of the config details because of the conda-smithy bug (but that looks like it might be fixed now)

My proposal is to land this (potentially with a re-render) and file a TODO for some cleanup (there probably is going to be some cleanup on the rerun side to potentially simplify some things here).

@traversaro I requested a re-review from you since this PR got quite long and verbose. Open to opinions if you wanted more cleanup immediately prior to merge.

@ntjohnson1 ntjohnson1 requested a review from traversaro August 22, 2025 07:18
@traversaro
Copy link
Contributor

Thanks a lot for all the work, your plan seems great!

@ntjohnson1 ntjohnson1 merged commit 662d8a6 into conda-forge:main Aug 22, 2025
28 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.24.0_hbd0829 branch August 22, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants