-
-
Notifications
You must be signed in to change notification settings - Fork 7
rerun-sdk v0.24.0 #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rerun-sdk v0.24.0 #70
Conversation
…nda-forge-pinning 2025.07.17.18.51.38
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17136603704. Examine the logs at this URL for more detail. |
|
|
This is quite perplexing:
But I just checked the rust 1.85 package which should have been being used and it should have Cargo 1.85 -- so where is this error coming from? I tried bumping the build number to re-kick CI. 🤞 |
|
Oops -- I think we just needed to re-render |
Leave osx non-arm alone Bump rust compiler version to 1.85.0 [ci skip] added user ntjohnson1 Add windows ar to bat, use conda cc for mac x86, linux try to use conda clang for ring Fix lint Windows needs exe One more try with flags Name the flags correctly More flag mangling for mac x86 Windows paths are a little different. Try unpathed option Mac x86 more specific flags not overriding so clobber I guess windows needs llvm compiler too One more flags change for today Extra space A little confused about the order of operations for generate vs target specific flags being respected in our recipe On mac we are just using the latest clang Actually change the exported flags
|
For context only llvm-ar works for |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.08.15.10.12.55
|
Just to understand, is the use of |
Not strongly intentional. My understanding is that the CONDA_PREFIX was exposed before running the build script so the location was unambiguous. I had just used CONDA_PREFIX for the other flags so stuck consistent to that Once things are unblocked I assume there will be some cleanup since all the bugs are at least clear. |
Ah, apparently |
|
Ok all the windows builds succeed but the ones that fail run out of disk space. Looking now if there is a config to control that. If you're familiar a pointer might speed things up or feel free to push directly. |
Sure, unfortunately the explicit option is Linux only (see conda-forge/conda-smithy#1949), but there is another commonly used workaround that is to use the |
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2025.08.21.14.01.57
|
Unfortunately rerendering is adding the Python 3.14 build, I guess there is some bug in conda-smithy or in the pinning. |
|
Yes, if you want to have a quick solution you can manually remove the files that end with |
|
My bad, actually the files that was necessary to modify were the one in |
…un-sdk-feedstock into 0.24.0_hbd0829
I added 3.9 back in as well. 🤞 |
Summary
My proposal is to land this (potentially with a re-render) and file a TODO for some cleanup (there probably is going to be some cleanup on the rerun side to potentially simplify some things here). @traversaro I requested a re-review from you since this PR got quite long and verbose. Open to opinions if you wanted more cleanup immediately prior to merge. |
|
Thanks a lot for all the work, your plan seems great! |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/16356380375 - please use this URL for debugging.