Check what tests might break #19044
Draft
Check what tests might break #19044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: memsharded <[email protected]>
AbrilRBS
force-pushed
the
ar/compat-optimization
branch
from
e5700f9 to
005ec79
Compare
memsharded
reviewed
Oct 7, 2025
| node.binary = original_binary | ||
| node._package_id = original_package_id | ||
|
|
||
| def _filter_compat_remotes(self, node, remotes): |
There was a problem hiding this comment.
I am not sure that explicit filtering the remotes is the way to go, I was thinking about the Remote._caching structure making it more powerful, but it also sounds challenging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
Optimization idea proposed by @memsharded, opening a PR to see if something breaks (with the current approach nothing should)