Skip to content

Conversation

davidsanfal
Copy link
Contributor

Changelog: (Feature | Fix | Bugfix): TODO
Docs: TODO

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@davidsanfal davidsanfal force-pushed the feature/pyinstaller-venv branch from 237122f to 0501a01 Compare October 3, 2025 10:14
@davidsanfal davidsanfal force-pushed the feature/pyinstaller-venv branch from 0501a01 to 57efa02 Compare October 3, 2025 10:27
@davidsanfal davidsanfal marked this pull request as ready for review October 4, 2025 09:01
@davidsanfal davidsanfal requested review from czoido and jcar87 October 6, 2025 17:19
env.prepend_path("PATH", self.bin_dir)
env.vars(self._conanfile).save_script(self.env_name)

def _create_venv(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about relying on a user configuration pointing to the python interpreter when not found in path?

"tools.system.package_manager:mode": "Mode for package_manager tools: 'check', 'report', 'report-installed' or 'install'",
"tools.system.package_manager:sudo": "Use 'sudo' when invoking the package manager tools in Linux (False by default)",
"tools.system.package_manager:sudo_askpass": "Use the '-A' argument if using sudo in Linux to invoke the system package manager (False by default)",
"tools.system.pip_manager:python_interpreter": "Path to the Python interpreter to be used to create the virtualenv",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tools.system.pip_manager:python_interpreter": "Path to the Python interpreter to be used to create the virtualenv",
"tools.system.pipenv:python_interpreter": "Path to the Python interpreter to be used to create the virtualenv",

what about tools.system.pipenv:python_interpreter ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants