Skip to content

Conversation

@kasunch
Copy link
Contributor

@kasunch kasunch commented Nov 19, 2020

Changelog: Fix: Fixes the issue with sensitive details are exposed in build log files

fixes #535

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@kasunch kasunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied the fix from an old source file and forgot to change the function arguments.

cpt/runner.py Outdated
self.runner = runner
self.printer = printer

def __call__(self, command):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps..! Need to add "hide_sensitive=True" for the arguments.

@uilianries uilianries added this to the 0.35.0 milestone Nov 23, 2020
@uilianries
Copy link
Member

It looks great. Is it possible add a test to check this new output?

Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member

Depends on conan-io/conan#8132

@uilianries uilianries self-assigned this Dec 1, 2020
@uilianries uilianries closed this Dec 1, 2020
@uilianries uilianries reopened this Dec 1, 2020
@uilianries uilianries removed the blocked label Dec 1, 2020
@uilianries
Copy link
Member

Depends on #538

@uilianries uilianries added blocked and removed blocked labels Dec 2, 2020
@uilianries uilianries closed this Dec 2, 2020
@uilianries uilianries reopened this Dec 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #536 (3110972) into develop (b6d6816) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #536      +/-   ##
===========================================
+ Coverage    79.13%   79.21%   +0.08%     
===========================================
  Files           41       41              
  Lines         4917     4932      +15     
===========================================
+ Hits          3891     3907      +16     
+ Misses        1026     1025       -1     
Impacted Files Coverage Δ
cpt/runner.py 91.52% <100.00%> (+0.18%) ⬆️
cpt/test/integration/docker_test.py 88.88% <100.00%> (+1.13%) ⬆️
cpt/test/integration/base.py 97.56% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d6816...3110972. Read the comment docs.

@uilianries uilianries merged commit c65cd53 into conan-io:develop Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sensitive details are exposed in the build log

4 participants