fix: add User-Agent to NetworkingModule http client

[cdanis]

Description (required)

Fixes #6411

What changes did you make and why?

For one of the OkHttpClient.Builder()s used inside the app, the one in OkHttpConnectionFactory.kt, there's a CommonHeaderRequestInterceptor class that adds User-Agent to outgoing requests.

The same isn't true of NetworkingModule.kt. So let's try adding it there.

Tests performed (required)

None, sorry.

I don't know Kotlin, do not have Android Studio installed, and really just want to see if this builds OK using the Github Actions flow (which I tried to run locally using act, but ran into emulator issues I couldn't quickly diagnose).

[rohit9625]

Please don't force push @cdanis. Your import will only work if we make this class public:

apps-android-commons/app/src/main/java/fr/free/nrw/commons/OkHttpConnectionFactory.kt

Line 53 in b9f353b

private class CommonHeaderRequestInterceptor : Interceptor {

[rohit9625]

And yes, it fixes the problem. Thank you so much for pointing this out.

Screen_recording_20250829_224847.webm

Please make that class public and push your changes. Your PR will be merged tomorrow once approved :)

[cdanis]

Please don't force push @cdanis. Your import will only work if we make this class public:

Apologies, I'm not used to force-pushes on PR branches in personal forks being a concern.

I've added a new commit making the referenced class public. Thanks so much!

[rohit9625]

Thanks @cdanis. Please link the correct issue #6411 in your description and comment on that issue so that I can assign you. Also, in Kotlin, we don't need to add public as classes are public by default; I forgot to mention that you might've just removed private. No worries it still works :)

[rohit9625]

All good, just fix the import as the correct import should be:

import fr.free.nrw.commons.CommonHeaderRequestInterceptor

Also, please remove the redundant public keyword from the CommonHeaderRequestInterceptor class. Thanks :)

[rohit9625]

Please fix the import with this import fr.free.nrw.commons.CommonHeaderRequestInterceptor.

[rohit9625]

Thanks for your quick help, @cdanis. It works great now and is ready to merge @nicolas-raoul :)

Screen_recording_20250829_234335.mp4

[github-actions]

✅ Generated APK variants!

• 🤖 Download betaDebugAPK
• 🤖 Download prodDebugAPK

[nicolas-raoul]

Thanks Chris for this very important fix, and Rohit for reviewing! Great collaboration. :-)

[RitikaPahwa4444]

Wow! Thanks a lot Chris and Rohit. I'll submit a patch today.