Fix warnings in LoginActivity.kt #6406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Kota-Jagadeesh, I reviewed the changes. I think you can make the LoginActivity even better by replacing deprecated code. I can still see 16 warnings (20 previously). Also, please remove the unused code instead of commenting it. Let me know if you need any help with migrating deprecated APIs. |
ok. i will work on it - update the PR shortly and let you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses warnings in
LoginActivity.ktunder the Kotlin header as part of issue #5996. The changes include:onEditorActionfunction.isNotEmpty()in theonTextChangedfunction for better Kotlin idiom.The functionality of the login process remains unaffected, and the app behaves as expected after these changes.
Part of issue #5996