Add support for noLinkCheck in codegen
#760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
no-link-check-codegen
branch
from
25f5004 to
421fa79
Compare
Codecov Report
@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 83.68% 83.68%
=======================================
Files 22 22
Lines 4580 4580
Branches 1239 1239
=======================================
Hits 3833 3833
Misses 483 483
Partials 264 264
|
Member
|
Looks like it is working! Can we have an updated cwl-utils PR to evaluate the result? |
GlassOfWhiskey
force-pushed
the
no-link-check-codegen
branch
from
421fa79 to
fa4b11b
Compare
mr-c
added a commit
to common-workflow-language/cwl-utils
that referenced
this pull request
Oct 25, 2023
1 task
GlassOfWhiskey
force-pushed
the
no-link-check-codegen
branch
2 times, most recently
from
da21572 to
837e664
Compare
mr-c
force-pushed
the
no-link-check-codegen
branch
from
837e664 to
3b99e49
Compare
mr-c
added a commit
to common-workflow-language/cwl-utils
that referenced
this pull request
Oct 31, 2023
mr-c
added a commit
to common-workflow-language/cwljava
that referenced
this pull request
Oct 31, 2023
mr-c
approved these changes
Oct 31, 2023
This commit introduces support for the `noLinkCheck` `jsonldPredicate` in the Schema SALAD codegen toolchain, and in particular in the `URILoader` stack. When `noLinkCheck` is set to `true`, no link checking is performed for all the underlying objects hierarchy. The need to propagate its value to the hierarchy makes it necessary to modify also the `LoadingOptions` data structure. All parsers but the Python one never perform link checking up to now, so this update makes no modification to their actual behaviour. However, it enables the `URILoader` classes to receive the `noLinkCheck` parameter for future implementations.
GlassOfWhiskey
force-pushed
the
no-link-check-codegen
branch
from
3b99e49 to
9c2a011
Compare
mr-c
added a commit
to common-workflow-language/cwljava
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for the
noLinkCheckjsonldPredicatein the Schema SALAD codegen toolchain, and in particular in theURILoaderstack. WhennoLinkCheckis set totrue, no link checking is performed for all the underlying objects hierarchy. The need to propagate its value to the hierarchy makes it necessary to modify also theLoadingOptionsdata structure.All parsers but the Python one never perform link checking up to now, so this update makes no modification to their actual behaviour. However, it enables the
URILoaderclasses to receive thenoLinkCheckparameter for future implementations.