Skip to content

Conversation

@Stellatsuu
Copy link

Related to : #2163

  • Added resource requirement minmax validation
  • Added validation when running --validate
  • Added related tests

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Stellatsuu !

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.19%. Comparing base (135a0c6) to head (5b7dd55).

Files with missing lines Patch % Lines
cwltool/checker.py 66.66% 1 Missing and 1 partial ⚠️
cwltool/process.py 50.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (135a0c6) and HEAD (5b7dd55). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (135a0c6) HEAD (5b7dd55)
17 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2179       +/-   ##
===========================================
- Coverage   85.12%   54.19%   -30.93%     
===========================================
  Files          46       46               
  Lines        8368     8383       +15     
  Branches     1956     1961        +5     
===========================================
- Hits         7123     4543     -2580     
- Misses        779     3331     +2552     
- Partials      466      509       +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +1847 to +1848
"file", ["tests/wf/bad_resreq_mnmx_clt.cwl", "tests/wf/bad_resreq_mnmx_wf.cwl"]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CWL descriptions need inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants