Skip to content

Conversation

@eug3nix
Copy link
Collaborator

@eug3nix eug3nix commented Jul 23, 2024

allow empty server valued in the connection form for postgres connections
add unix socket support for mariadb/mysql
refs: #437

test cases:
postgres connections should allow hostnames, IP addresses, empty values and absolute unix paths
mysql/mariadb connections should allow hostnames, IP addresses and absolute unix paths

postgres connections should look for sockets under default postgres socket path if server field is empty
postgres connections should look for sockets under the base path provided in the server field
mariadb/mysql connections should look for socket file specified by absolute socket path

other connection types: shoud work as before, file paths or empty values are not allowed
postgres/maridadb/mysql should work with ips and hostnames as before

allow empty server valued in the connection form for postgres
connections
add unix socket support for mariadb/mysql
refs: #437
@eug3nix eug3nix requested a review from plucik July 23, 2024 13:28
@eug3nix eug3nix self-assigned this Jul 23, 2024
@eug3nix eug3nix merged commit abb66d0 into dev Jul 23, 2024
@justinclift
Copy link

Cool, that looks like it's headed in the right direction. Do you reckon updating the associated help text for the field to mention unix sockets (etc) would be useful too? 😄

@eug3nix eug3nix deleted the 437_unix_socket_support branch August 6, 2024 13:33
eug3nix added a commit that referenced this pull request Aug 13, 2024
…ld (#438)

allow using unix domain socket paths in connection form -> server field
allow empty server values in the connection form for postgres connections
add unix socket support for mariadb/mysql
refs: #437
eug3nix added a commit that referenced this pull request Aug 13, 2024
@eug3nix
Copy link
Collaborator Author

eug3nix commented Aug 13, 2024

@justinclift I've added hints in server input placeholders per your suggestion.
These changes will be included in 1.1.1 version which we are planning to release soon.
Thanks!

eug3nix added a commit that referenced this pull request Aug 13, 2024
@justinclift
Copy link

Awesome. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants