[DEV-2790] add extra tags to subnets #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obezpalko
requested review from
liyaka,
CRThaze,
darenjacobs,
christopher-comet and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds extra tagging capability for subnets to support automated TGW integration.
- Introduces new variables for private and public subnet tags in variables.tf.
- Updates the VPC module in main.tf to merge EKS-related subnet tags with user-provided tag maps.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/comet_vpc/variables.tf | Adds new variables for private and public subnet tags. |
| modules/comet_vpc/main.tf | Updates subnet tag assignment to merge default and custom maps. |
Co-authored-by: Copilot <[email protected]>
liyaka
approved these changes
Jun 12, 2025
christopher-comet
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV-2790
required to automatically add subnets to TGW