Skip to content

OPIK-2164: Add inserts for feedback scores and logs #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Aug 1, 2025

Details

  • Add async inserts for feedback scores and logs as frequently as they are added in tiny batches, like on Online scoring

@thiagohora thiagohora force-pushed the thiagohora/OPIK-2164_test_async_inserts_part_2 branch from cdbc22d to 83ce8da Compare August 1, 2025 14:58
Copy link
Contributor

github-actions bot commented Aug 1, 2025

SDK E2E Tests Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 83ce8da.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 1, 2025

Backend Tests Results

  192 files  +  127    192 suites  +127   21m 40s ⏱️ + 17m 2s
4 184 tests +3 649  4 181 ✅ +3 685  3 💤 +2  0 ❌ ±0 
4 179 runs  +3 644  4 176 ✅ +3 680  3 💤 +2  0 ❌ ±0 

Results for commit 10ad55e. ± Comparison against base commit 3f685b6.

This pull request removes 36 and adds 3685 tests. Note that renamed tests count towards both.
com.comet.opik.api.resources.v1.events.DatasetEventListenerTest ‑ Unknown test
com.comet.opik.api.resources.v1.events.OnlineScoringEngineTest ‑ Unknown test
com.comet.opik.api.resources.v1.internal.UsageResourceTest ‑ Unknown test
com.comet.opik.api.resources.v1.jobs.TraceThreadsClosingJobTest ‑ Unknown test
com.comet.opik.api.resources.v1.priv.AttachmentResourceMinIOTest ‑ Unknown test
com.comet.opik.api.resources.v1.priv.AttachmentResourceTest ‑ Unknown test
com.comet.opik.api.resources.v1.priv.AuthenticationResourceTest ‑ Unknown test
com.comet.opik.api.resources.v1.priv.AutomationRuleEvaluatorsResourceTest ‑ Unknown test
com.comet.opik.api.resources.v1.priv.ChatCompletionsResourceTest ‑ Unknown test
com.comet.opik.api.resources.v1.priv.DatasetExperimentE2ETest ‑ Unknown test
…
com.comet.opik.api.resources.v1.events.DatasetEventListenerTest ‑ when__newOptimizationIsCreated__shouldBeSavedInTheDatabase
com.comet.opik.api.resources.v1.events.DatasetEventListenerTest ‑ when__optimizationIsDeleted__lastCreatedOptimizationDateShouldBeUpdated_
com.comet.opik.api.resources.v1.events.DatasetEventListenerTest$CreateExperimentEvent ‑ when__newExperimentIsCreated__shouldBeSavedInTheDatabase
com.comet.opik.api.resources.v1.events.DatasetEventListenerTest$DeleteExperimentEvent ‑ when__experimentIsDeleted__lastCreatedExperimentDateShouldBeUpdated
com.comet.opik.api.resources.v1.events.DatasetEventListenerTest$DeleteExperimentEvent ‑ when__experimentIsDeleted__lastCreatedExperimentDateShouldBeUpdated_
com.comet.opik.api.resources.v1.events.OnlineScoringEngineTest ‑ testExtractFromJsonWithDotKey(String, String)[1]
com.comet.opik.api.resources.v1.events.OnlineScoringEngineTest ‑ testExtractFromJsonWithDotKey(String, String)[2]
com.comet.opik.api.resources.v1.events.OnlineScoringEngineTest ‑ testExtractFromJsonWithDotKey(String, String)[3]
com.comet.opik.api.resources.v1.events.OnlineScoringEngineTest ‑ testPrepareLlmRequestWithInstructionStrategy
com.comet.opik.api.resources.v1.events.OnlineScoringEngineTest ‑ testPrepareLlmRequestWithToolCallingStrategy
…

♻️ This comment has been updated with latest results.

@thiagohora thiagohora force-pushed the thiagohora/OPIK-2164_test_async_inserts_part_2 branch from 9dda080 to 10ad55e Compare August 4, 2025 07:56
@thiagohora thiagohora marked this pull request as ready for review August 4, 2025 09:31
@thiagohora thiagohora requested a review from a team as a code owner August 4, 2025 09:31
@thiagohora thiagohora changed the title OPIK-2164: Add more async inserts OPIK-2164: Add inserts for feedback scores and logs Aug 4, 2025
@thiagohora thiagohora merged commit d6466c4 into main Aug 4, 2025
14 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-2164_test_async_inserts_part_2 branch August 4, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants