-
Notifications
You must be signed in to change notification settings - Fork 861
NA: Use push metrics, trace and logs ON Python Backend via Otel #2821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thiagohora
wants to merge
17
commits into
main
Choose a base branch
from
thiagohora/NA_use_push_metrics_on_python_metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NA: Use push metrics, trace and logs ON Python Backend via Otel #2821
thiagohora
wants to merge
17
commits into
main
from
thiagohora/NA_use_push_metrics_on_python_metrics
+246
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Backend Tests Results41 tests 39 ✅ 1m 56s ⏱️ Results for commit b127085. ♻️ This comment has been updated with latest results. |
515a779
to
69950ac
Compare
f538fb3
to
c682721
Compare
c682721
to
a5c6a73
Compare
bfc8d25
to
eaaf068
Compare
eaaf068
to
2e22a91
Compare
- Extract telemetry setup into clean, focused methods: - setup_otel_metrics(): Configure metrics export - setup_otel_traces(): Configure traces export - setup_otel_logs(): Configure logs export + handler - setup_console_logging(): Configure console verbosity - setup_otel_instrumentation(): Auto-instrumentation with checks - Fix double instrumentation warnings by adding proper checks - Add OPIK_CONSOLE_LOG_LEVEL environment variable for console control - Improve code maintainability and testability - Preserve all existing telemetry functionality Benefits: - Each method has single responsibility - Better organization and readability - Fixed double instrumentation bug - Independent console and OTEL log level control - Easier to test and modify individual components
andrescrz
reviewed
Aug 8, 2025
4f3c1a4
to
e98dc31
Compare
andrescrz
previously approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details