Skip to content

Adding --local flag to opik.sh for local development mode #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

YarivHashaiComet
Copy link
Contributor

@YarivHashaiComet YarivHashaiComet commented Jul 18, 2025

Supporting --local flag & --local --migrate which runs frontend & backend locally along side with the needed containers for local development

image
Screen.Recording.2025-07-18.at.14.13.14.mov

@YarivHashaiComet YarivHashaiComet requested a review from Copilot July 18, 2025 09:29
Copilot

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

Python Backend Tests Results

41 tests   39 ✅  2m 54s ⏱️
 1 suites   2 💤
 1 files     0 ❌

Results for commit 25b4854.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

Backend Tests Results

4 368 tests   4 365 ✅  20m 56s ⏱️
  186 suites      3 💤
  186 files        0 ❌

Results for commit 25b4854.

♻️ This comment has been updated with latest results.

@YarivHashaiComet YarivHashaiComet force-pushed the OPIK-2079-supporting-local-development-flag-opik-sh branch from f26c57b to 50f9047 Compare July 18, 2025 10:19
@YarivHashaiComet YarivHashaiComet requested a review from Copilot July 18, 2025 10:21
Copilot

This comment was marked as outdated.

@YarivHashaiComet YarivHashaiComet force-pushed the OPIK-2079-supporting-local-development-flag-opik-sh branch from 50f9047 to b3d19fe Compare July 18, 2025 10:27
@YarivHashaiComet YarivHashaiComet requested a review from Copilot July 18, 2025 10:28
Copilot

This comment was marked as outdated.

@YarivHashaiComet YarivHashaiComet force-pushed the OPIK-2079-supporting-local-development-flag-opik-sh branch 2 times, most recently from 7750812 to 1345a74 Compare July 18, 2025 11:06
@YarivHashaiComet YarivHashaiComet requested a review from Copilot July 18, 2025 11:16
Copilot

This comment was marked as outdated.

@YarivHashaiComet YarivHashaiComet force-pushed the OPIK-2079-supporting-local-development-flag-opik-sh branch 2 times, most recently from dcec4fb to 76b934c Compare July 18, 2025 11:21
@YarivHashaiComet YarivHashaiComet requested a review from Copilot July 18, 2025 11:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds local development functionality to the opik.sh and opik.ps1 scripts, allowing developers to run frontend and backend services locally while using containerized dependencies. The implementation supports automatic configuration, database migrations, and provides a unified development environment setup.

Key changes include:

  • Addition of --local flag for starting local development environment with containerized dependencies
  • Addition of --migrate flag for running database migrations in local mode
  • Comprehensive local development workflow including requirement checks, configuration management, and service orchestration

Reviewed Changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated 7 comments.

File Description
opik.sh Adds local development functions, colored logging, and command-line flag handling for bash environments
opik.ps1 Implements equivalent local development functionality for PowerShell environments with Windows compatibility

@YarivHashaiComet YarivHashaiComet force-pushed the OPIK-2079-supporting-local-development-flag-opik-sh branch from 76b934c to 5cfe491 Compare July 18, 2025 11:31
@YarivHashaiComet YarivHashaiComet marked this pull request as ready for review July 18, 2025 13:00
@YarivHashaiComet YarivHashaiComet requested a review from a team as a code owner July 18, 2025 13:00
Copy link
Member

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has similar problems to its predecesor: #2753

Basically, it copies and pastes lots of logic, configuration etc. that it's already exits across the different scripts, docker files etc. This would become very hard to maintain.

I suggest again exploring the approach with docker groups as suggested in OPIK-1095. With that, you can accomplish what you want quite easily.

@andrescrz
Copy link
Member

Closed due to inactivity. Reopen if needed.

@andrescrz andrescrz closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants