Add MultiInOutTransformer #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinzh
force-pushed
the
u/austinzh/stringindexer_multiple_colums
branch
from
905fd03 to
65d672c
Compare
austinzh
force-pushed
the
u/austinzh/stringindexer_multiple_colums
branch
from
609eef9 to
7744013
Compare
austinzh
force-pushed
the
u/austinzh/stringindexer_multiple_colums
branch
from
855e7a5 to
33d061d
Compare
mleap-core/src/main/scala/ml/combust/mleap/core/feature/StringIndexerModel.scala
Outdated
Show resolved
Hide resolved
mleap-spark-base/src/main/scala/org/apache/spark/ml/bundle/MultiInOutFormatSparkOp.scala
Outdated
Show resolved
Hide resolved
mleap-spark-base/src/main/scala/org/apache/spark/ml/bundle/MultiInOutFormatSparkOp.scala
Outdated
Show resolved
Hide resolved
mleap-spark/src/main/scala/org/apache/spark/ml/bundle/ops/feature/BinarizerOp.scala
Show resolved
Hide resolved
mleap-spark/src/main/scala/org/apache/spark/ml/bundle/ops/feature/StopWordsRemoverOp.scala
Show resolved
Hide resolved
mleap-spark/src/main/scala/org/apache/spark/ml/bundle/ops/feature/StringIndexerOp.scala
Show resolved
Hide resolved
OneHotEncoder already implement a logic to due with multiple input columns and output columns in mleap It's better to reuse what is ready done
If outputCol not set, we should check outputCols first If outputCols not set, we get the default value of outputCol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Transformer is added to better support spark transformers that has inputCols and outputCols.
The rules are:
In Spark side, all parameters save/load as its, we use the information in the NodeShape to determine we should set inputCol/outputCol or inputCols/outputCols.
In MLeap side, when load mode, we will transformer
"input" -> "input0"
"output" -> "output0" so that transformer can build correct input/output schema.
This approach implemented in two place.