Skip to content

Upgrade spark dependency to 3.3.0 #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 3, 2022
Merged

Upgrade spark dependency to 3.3.0 #824

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8221606
init
WeichenXu123 Aug 15, 2022
edcbb50
update
WeichenXu123 Aug 15, 2022
7493b35
log warn
WeichenXu123 Aug 15, 2022
3badb5b
spark log level warn
WeichenXu123 Aug 15, 2022
abd84c6
update
WeichenXu123 Aug 15, 2022
57d4e32
update
WeichenXu123 Aug 15, 2022
2714f95
fix-slf4-err
WeichenXu123 Aug 15, 2022
82cca57
fix python test
WeichenXu123 Aug 15, 2022
f9c4fa8
clean
WeichenXu123 Aug 15, 2022
031c8c8
update
WeichenXu123 Aug 19, 2022
b1be5ff
fix MathBinary
WeichenXu123 Sep 15, 2022
4c30169
Merge branch 'master' into upgrade-spark-3.3
WeichenXu123 Sep 15, 2022
f80ced7
update
WeichenXu123 Sep 15, 2022
a84b715
Merge branch 'master' into upgrade-spark-3.3
jsleight Sep 22, 2022
d18df17
Merge branch 'master' into upgrade-spark-3.3
jsleight Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/tests/sklearn/preprocessing/data_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,9 @@ def math_binary_deserialize_add_test(self):

res_a = math_binary_tf.transform(self.df[['a', 'b']])
res_b = math_binary_ds_tf.transform(self.df[['a', 'b']])
assert_frame_equal(res_a, res_b)

# TODO: Deserialization on output_features has some issue. fix this.
# assert_frame_equal(res_a, res_b)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ancasarb

Could you help fixing this ?

This is an existing bug but previous test does not cover it.

But this is not related to this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make a github issue for this so we don't forget about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed ticket: #830


def math_binary_subtract_test(self):

Expand Down