Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Jan 22, 2024

  • Copy bindings are moved to MakeDataclass
  • All dataclass objects become pickleable
  • To enable this, todict() now only exports data attributes
  • This requires the following breaking changes:
    • Rotation3d.quat becomes a property
    • {Rigid3d,Sim3d}.matrix becomes a function
    • Image.num_points2D becomes a function
  • for Camera this would remove useful attributes from the summary (like param_info) so we explicitly pass the list of data attributes

Base automatically changed from sarlinpe/fix-bug-summary to master January 23, 2024 19:42
@sarlinpe sarlinpe merged commit 6f0096d into master Jan 23, 2024
@sarlinpe sarlinpe deleted the sarlinpe/pickling branch January 23, 2024 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants