Fix Postgres UPDATE ... LIMIT bug #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subquery should only return a single row so there is no need to use IN. Using "=" avoids a situation where the planner can sidestep the LIMIT in the subquery.
|
We're having the same problem using postgres 11. |
SaitoJP
added a commit
to SaitoJP/delayed_job_active_record
that referenced
this pull request
Jul 8, 2020
The subquery should only return a single row so there is no need to use IN. Using "=" avoids a situation where the planner can sidestep the LIMIT in the subquery. collectiveidea#169
sauy7
added a commit
to fishbrain/delayed_job_active_record
that referenced
this pull request
Sep 11, 2021
albanpeignier
added a commit
to enroute-mobi/chouette-core
that referenced
this pull request
Oct 11, 2022
…ed Job reserve subquery Approach described into collectiveidea/delayed_job_active_record#169
|
Having same issue and this merge request will resolve it, why don't we merge it in to master branch? |
|
Thank you for this PR! I was trying to pin down this issue for a long time... It's a pity it's not merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in #143.
The subquery returns 1 row so there is no need to use "IN" as the "=" operator will work just fine. Additionally, using "=" doesn't allow the query planner to choose a plan that can sidestep the LIMIT.