Allow enable/disable Audit for all classes but only locally #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The proposed changes would work even if the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already possible to disable Audits locally for a specific object or to an entire model
but it not possible to do this to all classes. The only way would be to disable it at the module level with
Audited.auditing_enabled = false, but this will disable audits for the entire process, which is undesirable in a multi-threaded environment like Sidekiq or Puma.So I am opening this PR to suggest/add this feature.
Let me know if makes sense for the gem or if i need to make any changes to make it accepted.