Define audit_class per model #641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuldeepaggarwal
force-pushed
the
define_audit_class_per_model
branch
3 times, most recently
from
a7cd5f4 to
ffdc4c4
Compare
kuldeepaggarwal
force-pushed
the
define_audit_class_per_model
branch
from
ffdc4c4 to
7d9b0d6
Compare
|
Waiting for this one :) |
|
I like the idea here, but I'd like to see some tests exercising it. Also, we changed |
|
This will allow us to have multiple tables of audit logs? So different models could log to different audit log tables? |
Same thing already available for quite long time in PaperTrail: https://github.com/paper-trail-gem/paper_trail#6a-custom-version-classes |
|
Moved forward this PR here #735 -- some edge cases fixed, e.g. audited_classes were not correctly collected, also improved test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471