fix: remove redundant Required<> from input and output type definitions #5033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Required<>
utility type from bothinput
andoutput
type definitionsProblem
The
Required<>
utility type in both type definitions was redundant:The type guards
T extends { _zod: { input: any } }
andT extends { _zod: { output: any } }
already ensure thatinput
andoutput
are required properties. If either were optional, the conditions would fail and returnunknown
.This redundant
Required<>
caused TS2615 errors in TypeScript 5.9+ when using recursive schemas because it introduced unnecessary mapped types in circular reference chains.Solution
Simplified both type definitions to:
The type behavior remains exactly the same, but without the redundant mapped type transformations.
Test plan
Related
Fixes #5035
🤖 Generated with Claude Code