Skip to content

Whisper stt api #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2023
Merged

Whisper stt api #58

merged 5 commits into from
Mar 20, 2023

Conversation

@tluyben
Copy link
Contributor

@tluyben tluyben commented Mar 19, 2023

Whisper is working.

@cogentapps
Copy link
Owner

Works great! Thank you for implementing it, this is one of the most asked for features.

It's late here but I will merge this tomorrow. I'll do a quick review to note down any tweaks I want to make.

cogentapps
cogentapps reviewed Mar 19, 2023
View reviewed changes
app/src/speech-recognition-types.d.ts
@@ -0,0 +1,133 @@
declare global {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does TypeScript not have built-in types for SpeechRecognition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not get it working without these; I did it before in JS, but the only examples I could find carried their own definitions like this. Probably it can be done nicer indeed.

@tluyben tluyben mentioned this pull request Mar 19, 2023
Closed
@tluyben
Copy link
Contributor Author

tluyben commented Mar 19, 2023

Works great! Thank you for implementing it, this is one of the most asked for features.

It's late here but I will merge this tomorrow. I'll do a quick review to note down any tweaks I want to make.

Improvements can be many : https://github.com/saharmor/whisper-playground/tree/main/interface/src, we can learn from this , because it does incremental transcribing which would be vastly better than chunking.

@cogentapps cogentapps merged commit 95bf0ae into cogentapps:main Mar 20, 2023
smartman1234 added a commit to smartman1234/chat-with-gpt that referenced this pull request Jun 26, 2023
@smartman1234
improvements, see comments: cogentapps/chat-with-gpt#58
68269c1
felicehoc-elite added a commit to felicehoc-elite/chat-with-gpt that referenced this pull request Aug 7, 2023
@felicehoc-elite
improvements, see comments: cogentapps/chat-with-gpt#58
6a27edd
pulchra-elite added a commit to pulchra-elite/ChatGpt that referenced this pull request Aug 7, 2023
@pulchra-elite
improvements, see comments: cogentapps/chat-with-gpt#58
4dac76e
dark-knight37 pushed a commit to dark-knight37/chat-with-gpt that referenced this pull request Aug 21, 2023
improvements, see comments: cogentapps/chat-with-gpt#58
dccf67b
danieldev0724 added a commit to danieldev0724/chat-with-gpt that referenced this pull request Aug 21, 2023
@danieldev0724
improvements, see comments: cogentapps/chat-with-gpt#58
389736d
Mark-Garner added a commit to Mark-Garner/chat-with-gpt that referenced this pull request Jul 18, 2024
@Mark-Garner
improvements, see comments: cogentapps/chat-with-gpt#58
5c1df94
WilliamDarkness pushed a commit to WilliamDarkness/chat-with-gpt that referenced this pull request Jul 18, 2024
@williambrace0724
improvements, see comments: cogentapps/chat-with-gpt#58
975b7a0
PowerHazzard added a commit to PowerHazzard/chat-with-gpt that referenced this pull request Jul 18, 2024
@PowerHazzard
improvements, see comments: cogentapps/chat-with-gpt#58
ffb4499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cogentapps cogentapps cogentapps left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tluyben @cogentapps