Skip to content

Conversation

markgoddard
Copy link
Member

@markgoddard markgoddard commented Jun 27, 2025

This change adds an Identity message, an IdentityService gRPC service and an IdentityClient to the Connect client. Identity represents a SPIFFE workload identity with corresponding SPIRE selectors that define the attestation criteria. The gRPC service provides GetIdentity and ListIdentities RPCs.

@markgoddard markgoddard self-assigned this Jun 27, 2025
Copy link

github-actions bot commented Jun 27, 2025

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 27, 2025, 4:30 PM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational components for managing identities within the system. It defines the Identity message, the IdentityService for accessing and managing identities, and integrates the new service into the client SDK.

Highlights

  • Identity Message: Adds the Identity message, which includes fields for ID, organization ID, trust zone ID, cluster ID, attestation policy ID, AP binding ID, workload ID, SPIFFE ID, parent ID, selectors, federations, and creation timestamp.
  • Identity Service: Introduces the IdentityService with GetIdentity and ListIdentities RPCs for retrieving individual identities and listing identities with filtering.
  • Connect Client: Adds the Identity client to the ClientSet for interacting with the Identity service.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the IdentityService and its corresponding client. The protobuf definitions are clear, and the client implementation is straightforward. There's one minor issue with an inaccurate comment in the new client implementation.

@markgoddard markgoddard requested a review from jsnctl July 1, 2025 10:36
@markgoddard markgoddard merged commit 9285968 into main Jul 1, 2025
5 checks passed
@markgoddard markgoddard deleted the identity branch July 1, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants