Skip to content

Conversation

markgoddard
Copy link
Member

Currently this does not support publishing workloads, only listing them.

@markgoddard markgoddard self-assigned this Jun 26, 2025
@markgoddard markgoddard requested review from jsnctl and mattbates June 26, 2025 11:55
Copy link

github-actions bot commented Jun 26, 2025

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 26, 2025, 11:59 AM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new client for interacting with the Workload service within the cofide-api-sdk. It provides the necessary interfaces, implementations, and fake clients to enable listing of workloads.

Highlights

  • New WorkloadClient: I've added a new WorkloadClient to the Connect client SDK, allowing programmatic interaction with the Workload service. This client currently supports listing workloads.
  • ClientSet Integration: The new WorkloadClient has been integrated into the main ClientSet interface and its implementation, making it accessible alongside other existing clients.
  • Fake Client and Test Utilities: A corresponding fake WorkloadClient implementation has been added for testing purposes, along with new test utilities to generate fake Kubernetes Pod Workload data.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the WorkloadClient to the Connect client, enabling listing workloads. The changes include adding necessary protobuf definitions, client implementations, and fake implementations for testing. The review focuses on improving code consistency and readability.

Currently this does not support publishing workloads, only listing them.
Base automatically changed from wl-node-uid to main June 26, 2025 13:03
Copy link
Contributor

@jsnctl jsnctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than Gemini suggestion on receiver method

@markgoddard markgoddard enabled auto-merge June 27, 2025 15:21
@markgoddard markgoddard requested a review from jsnctl June 27, 2025 15:21
@markgoddard markgoddard merged commit 3bcce04 into main Jun 27, 2025
5 checks passed
@markgoddard markgoddard deleted the workload-client branch June 27, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants