Skip to content

Conversation

jsnctl
Copy link
Contributor

@jsnctl jsnctl commented Sep 29, 2025

Enabling change for cofide/cofidectl#319

@jsnctl jsnctl enabled auto-merge (squash) September 29, 2025 09:13
Copy link

Summary of Changes

Hello @jsnctl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the APKubernetes attestation policy by introducing a dns_name_templates field. This addition allows for more granular control and flexibility in defining attestation policies that can match against specific DNS name patterns within Kubernetes environments. The changes primarily involve updating the core protobuf schema and regenerating the associated Go and TypeScript code.

Highlights

  • Protobuf Definition Update: The APKubernetes message in attestation_policy.proto now includes a new repeated string dns_name_templates field, enabling the specification of DNS name patterns for attestation policies.
  • Generated Code Updates: The Go and TypeScript generated protobuf files have been updated to reflect the new dns_name_templates field, including its definition in the APKubernetes struct/interface and a corresponding getter method in Go.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 29, 2025, 9:13 AM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a dns_name_templates field to the APKubernetes protobuf message. The change is straightforward and the generated code for Go and TypeScript has been updated accordingly. My review includes one suggestion to improve the maintainability of the protobuf definition by adding a comment to the new field. It would also be beneficial to update existing tests to cover this new field in this or a follow-up pull request.

@jsnctl jsnctl merged commit 6c1046d into main Sep 29, 2025
5 checks passed
@jsnctl jsnctl deleted the jsnctl/ap-dns-template branch September 29, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants