chore: remove deprecated AgentService.UpdateTrustZoneBundle RPC #120
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @markgoddard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on streamlining the AgentService by eliminating a deprecated RPC call and its related data structures. The primary purpose is to clean up the API surface and maintain consistency following the relocation of this specific functionality to a different service.
Highlights
- RPC Removal: The deprecated
UpdateTrustZoneBundleRPC and its associated request and response message types have been completely removed from theAgentService. - Code Cleanup: All generated Go and TypeScript protobuf files have been updated to reflect the removal of the RPC, including constant definitions, client and server interfaces, handler implementations, and message indexing.
- API Refactoring: This change is part of a larger refactoring effort, as the
UpdateTrustZoneBundlefunctionality has been relocated to theTrustZoneService.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated AgentService.UpdateTrustZoneBundle RPC. The changes to the protobuf definition and the generated Go and TypeScript files are correct and consistent. However, the pull request appears to be incomplete as it does not update the client code that uses this RPC, which will likely cause a broken build. Please see the detailed comment for more information.
This moved to the TrustZoneService.
markgoddard
force-pushed
the
rm-agent-update-tz-bundle
branch
from
a457b2a to
e16b76a
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request cleanly removes the deprecated AgentService.UpdateTrustZoneBundle RPC. The changes are comprehensive, covering the protobuf definition, all generated Go and TypeScript code, the client implementation, and associated tests. The removal is consistent across the codebase, and the resulting code is clean. This is a good maintenance change that improves the codebase by removing obsolete code.
2 participants
This moved to the TrustZoneService.