Skip to content

Conversation

yoctozepto
Copy link
Contributor

Fixes #110

@yoctozepto yoctozepto requested a review from markgoddard August 11, 2025 16:02
Copy link

github-actions bot commented Aug 11, 2025

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedAug 12, 2025, 9:29 AM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yoctozepto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically removes deprecated fields from various Protocol Buffer message definitions and their generated Go and TypeScript code. The corresponding field numbers and names have been reserved in the .proto files to prevent accidental reuse and ensure forward compatibility, addressing issue #110.

Highlights

  • APBinding Cleanup: Deprecated trust_zone, policy, and federates_with fields, along with their associated getter methods, have been removed from the APBinding message and its generated Go and TypeScript code.
  • Cluster Cleanup: The deprecated trust_zone field and its getter method have been removed from the Cluster message and its generated Go and TypeScript code.
  • Federation Cleanup: The deprecated from and to fields and their getter methods have been removed from the Federation message and its generated Go and TypeScript code.
  • TrustZone Cleanup: Deprecated federations and attestation_policies fields, their getter methods, and related imports have been removed from the TrustZone message and its generated Go and TypeScript code.
  • Protocol Buffer Field Reservation: The field numbers and names of all removed deprecated fields have been explicitly reserved in their respective .proto files to prevent future conflicts and maintain wire compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@yoctozepto
Copy link
Contributor Author

draft to discuss it a bit more (see the issue)

also need to fix buf step to allow breaking changes (at least the "good ones" with reserved fields)

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes deprecated fields from several protobuf definitions and reserves their tags and names. This is a good practice for API evolution as it prevents accidental reuse and maintains a degree of backward compatibility. The generated Go and TypeScript files are all updated consistently with the schema changes. The changes are clean, correct, and improve the maintainability of the API definitions.

@markgoddard
Copy link
Member

also need to fix buf step to allow breaking changes (at least the "good ones" with reserved fields)

Added the buf skip breaking label

Copy link
Member

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait a couple of weeks before merging.

@yoctozepto yoctozepto marked this pull request as ready for review August 12, 2025 12:57
@yoctozepto
Copy link
Contributor Author

also need to fix buf step to allow breaking changes (at least the "good ones" with reserved fields)

Added the buf skip breaking label

Thanks!

LGTM, let's wait a couple of weeks before merging.

As we use released versions and this is internal, I don't think there is much point in waiting now.

In the meantime, I will make sure there are no uses of these fields in the depending projects.

@yoctozepto yoctozepto enabled auto-merge (squash) August 12, 2025 12:59
@yoctozepto
Copy link
Contributor Author

In the meantime, I will make sure there are no uses of these fields in the depending projects.

'Tis done!

@yoctozepto yoctozepto self-assigned this Sep 3, 2025
@yoctozepto yoctozepto merged commit 375cba2 into main Sep 3, 2025
5 of 6 checks passed
@yoctozepto yoctozepto deleted the rp/remove-deprecated branch September 3, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated fields

2 participants