-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Remove UpdateManagedTrustZoneBundle from TrustZoneClient #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @markgoddard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the TrustZone bundle update functionality by consolidating two distinct methods, UpdateTrustZoneBundle
and UpdateManagedTrustZoneBundle
, into a single, more versatile UpdateTrustZoneBundle
method. This new method now explicitly accepts a trustZoneID
, allowing it to handle updates for both local and managed trust zones uniformly.
Highlights
- API Consolidation: I've merged the
UpdateTrustZoneBundle
andUpdateManagedTrustZoneBundle
methods within theTrustZoneClient
interface and its implementation into a singleUpdateTrustZoneBundle
method. - Explicit Trust Zone ID: The consolidated
UpdateTrustZoneBundle
now explicitly requires atrustZoneID
as an argument, making its scope clear and removing the implicit agent-ID based bundle updates. - Simplified Internal Logic: I've removed the
getAgentIDFromMetadata
helper function and its relatedgoogle.golang.org/grpc/metadata
import, simplifying the internal client logic. - Enhanced Fake Client Behavior: The fake client's
UpdateTrustZoneBundle
implementation has been updated to support partial bundle updates, mergingX509Authorities
,JwtAuthorities
,RefreshHint
, andSequenceNumber
if a bundle for the giventrustZoneID
already exists.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request refactors the TrustZoneClient
by merging UpdateTrustZoneBundle
and UpdateManagedTrustZoneBundle
into a single method. The review includes suggestions to enhance the fake implementation and its tests for better correctness and coverage.
UpdateTrustZoneBundle now accepts a trust zone ID, and can be used for both the local and managed trust zones.
7ef8dc5
to
c4747c9
Compare
UpdateTrustZoneBundle now accepts a trust zone ID, and can be used for
both the local and managed trust zones.