Skip to content

Conversation

markgoddard
Copy link
Member

This RPC will replace the one in the agent service.

Also adds new methods to the Go client, ported from the equivalent ones
in the agent service.

This RPC will replace the one in the agent service.

Also adds new methods to the Go client, ported from the equivalent ones
in the agent service.
@markgoddard markgoddard self-assigned this Jul 9, 2025
@markgoddard markgoddard requested review from jsnctl and mattbates July 9, 2025 15:15
Copy link

github-actions bot commented Jul 9, 2025

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 9, 2025, 3:15 PM

@markgoddard markgoddard enabled auto-merge (rebase) July 9, 2025 15:16
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new UpdateTrustZoneBundle RPC to the TrustZoneService, which is intended to replace a similar RPC currently residing in the agent service. This change also includes porting the corresponding client-side methods to the Go client for the TrustZoneService, enabling trust zone bundle updates directly through this service.

Highlights

  • New RPC Definition: Added the UpdateTrustZoneBundle RPC to the TrustZoneService protobuf definition. This includes defining the UpdateTrustZoneBundleRequest message, which contains a bundle and trust_zone_id, and an empty UpdateTrustZoneBundleResponse message.
  • Generated Code Updates: Regenerated Go and TypeScript protobuf, gRPC, and Connect-Go client/server stubs to incorporate the new UpdateTrustZoneBundle RPC across all relevant generated files.
  • Go Client Enhancements: Extended the Go TrustZoneClient interface and its implementation with new UpdateTrustZoneBundle and UpdateManagedTrustZoneBundle methods, providing programmatic access to update trust zone bundles.
  • Fake Client and Test Coverage: Updated the fake TrustZone client and its associated unit tests to simulate and verify the behavior of the new bundle update RPCs, ensuring proper functionality and a clear migration path from the agent service.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new RPC, UpdateTrustZoneBundle, to the TrustZoneService. It also adds corresponding methods to the Go client, mirroring those in the agent service. The code changes include modifications to protobuf definitions, gRPC service definitions, and connect service implementations to accommodate the new RPC.

@markgoddard markgoddard merged commit 659b893 into main Jul 9, 2025
5 checks passed
@markgoddard markgoddard deleted the update-tz-bundle branch July 9, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants