-
Notifications
You must be signed in to change notification settings - Fork 0
Adds OIDCDiscoveryEndpoint to Cluster proto #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jsnctl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new OIDC_discovery_endpoint
field to the Cluster
protobuf definition. This addition enables the storage and retrieval of OIDC discovery endpoint URLs associated with a cluster, and the changes are reflected in the automatically generated Go and TypeScript protobuf files.
Highlights
- Protobuf Schema Update: I've added a new optional string field,
OIDC_discovery_endpoint
, to theCluster
message inproto/cluster/v1alpha1/cluster.proto
. This field is assigned protobuf tag11
. - Generated Go Code: The generated Go file
gen/go/proto/cluster/v1alpha1/cluster.pb.go
has been updated to include theOIDCDiscoveryEndpoint
field in theCluster
struct and a correspondingGetOIDCDiscoveryEndpoint()
getter method. - Generated TypeScript Code: The generated TypeScript file
gen/ts/proto/cluster/v1alpha1/cluster_pb.ts
now includes theOIDCDiscoveryEndpoint
as an optional string property in theCluster
type definition.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an OIDC discovery endpoint field to the Cluster
protobuf message. The change is propagated to the generated Go and TypeScript files. My review focuses on ensuring the new protobuf field adheres to common style conventions, which will in turn produce idiomatic generated code.
Uh oh!
There was an error while loading. Please reload this page.