Skip to content

Conversation

jsnctl
Copy link
Contributor

@jsnctl jsnctl commented Jul 1, 2025

  • Adds OIDC discovery endpoint to Cluster proto

@jsnctl jsnctl self-assigned this Jul 1, 2025
@jsnctl jsnctl requested review from markgoddard and mattbates July 1, 2025 15:09
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 2, 2025, 8:26 AM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jsnctl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new OIDC_discovery_endpoint field to the Cluster protobuf definition. This addition enables the storage and retrieval of OIDC discovery endpoint URLs associated with a cluster, and the changes are reflected in the automatically generated Go and TypeScript protobuf files.

Highlights

  • Protobuf Schema Update: I've added a new optional string field, OIDC_discovery_endpoint, to the Cluster message in proto/cluster/v1alpha1/cluster.proto. This field is assigned protobuf tag 11.
  • Generated Go Code: The generated Go file gen/go/proto/cluster/v1alpha1/cluster.pb.go has been updated to include the OIDCDiscoveryEndpoint field in the Cluster struct and a corresponding GetOIDCDiscoveryEndpoint() getter method.
  • Generated TypeScript Code: The generated TypeScript file gen/ts/proto/cluster/v1alpha1/cluster_pb.ts now includes the OIDCDiscoveryEndpoint as an optional string property in the Cluster type definition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jsnctl jsnctl added this to the m29 milestone Jul 1, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an OIDC discovery endpoint field to the Cluster protobuf message. The change is propagated to the generated Go and TypeScript files. My review focuses on ensuring the new protobuf field adheres to common style conventions, which will in turn produce idiomatic generated code.

@jsnctl jsnctl enabled auto-merge (squash) July 1, 2025 15:14
@jsnctl jsnctl changed the title Adds OIDCDiscoveryProvider to Cluster proto Adds OIDCDiscoveryEndpoint to Cluster proto Jul 2, 2025
@jsnctl jsnctl merged commit da90296 into main Jul 2, 2025
5 checks passed
@jsnctl jsnctl deleted the jsnctl/add-oidc-endpoint-to-cluster branch July 2, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants