Post editor #262
Merged
Post editor #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove toast.success("Saved") when post is autosaved
- change editor background colours
- remove title and textaread border
patrickhladun
requested review from
NiallJoeMaher and
pkspyder007
as code owners
|
@patrickhladun is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@xiaoniuniu89 will any of these changes break anything for you? I know you are the only person actively working on this. |
Contributor
|
@patrickhladun some conflicts to clean up 😉 |
Contributor
|
It looks good to me, can't see anything breaking!! but ..... we should definitely tackle testing soon!! Also maybe a story about refactoring some of the functionality into some separate modules. This page is getting hard to maintain!! This commit does a good job with that!! I can shoehorn some refactoring in while I am doing the editor!! |
Contributor
Author
|
@NiallJoeMaher Conflicts are resolved now. |
NiallJoeMaher
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Add post editor sticky header and preview icon button * Remove toaster on save event * Create editor specific layout * Add EditorHints component to display the article editor hints and tips * Use EditorHints and LayoutEditor components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Codu Pull Request 💻
Pull Request details:
Issue #183 was created to improve the Save notification and make it less distracting. This feature aims to try an alternative design for the article editor.
The Save notification is coded with the toaster component. When the post is saved automatically, it pops up from the top and disappears. There are options to set a different location for the notification, but this doesn't help much.
The "Save" notification must be more subtle to not distract the user every few seconds when the article is auto-saved.
We have the Saved information and publish button at the bottom of the editor. So removing the toaster "Save" notification helps, and you still have Saved info on the bottom of the editor.
But ideally, I would like to have this visible while I scroll up and down my article when writing it. To fix this, I removed the Publish button from the bottom of the editor and moved it to the top of that page in a top bar that sticks to the top when scrolling. This way publish button and Saved info will always be available.
I have added a Preview button to the top bar with an "Eye" icon.
I have removed sidebars and borders from the editor. Then I have added EditorHints component that adds "How to use the editor" at the bottom of the editor. This can be closed with "X" button but it will show again page is refreshed. Ideally, it would need to be added to the user settings so that when the user closes it, it will remain closed, and you could turn it on again in the settings or user dropdown menu.
I have added a new Layout component to remove the website footer from the article editor to make it even cleaner.
Here is a screenshot of how this could look with the editor action buttons in the header. The "Your posts" and "New Post" buttons could be put in the dropdown user menu instead and other website links removed.
Any Breaking changes:+