Add avatar to the onboarding flow #1113
+159
−53
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { toast } from "sonner"; | ||
| import { uploadFile } from "./s3helpers"; | ||
|
|
||
| type UploadToUrlProps = { | ||
| file: File; | ||
| getUploadUrl: (data: { size: number; type: string }) => Promise<string>; | ||
| updateUserPhotoUrl: (data: { | ||
| url: string; | ||
| }) => Promise<{ role: string; id: string; name: string }>; | ||
| }; | ||
|
|
||
| type UploadResult = { | ||
| status: "success" | "error" | "loading"; | ||
| fileLocation: string; | ||
| }; | ||
|
|
||
| export const imageUploadToUrl = async ({ | ||
| file, | ||
| updateUserPhotoUrl, | ||
| getUploadUrl, | ||
| }: UploadToUrlProps): Promise<UploadResult> => { | ||
| if (!file) { | ||
| toast.error("Invalid file upload."); | ||
| return { status: "error", fileLocation: "" }; | ||
| } | ||
|
Comment on lines
+17
to
+25
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance initial file validation While the initial file check is a good start, consider implementing more comprehensive validation as suggested in the previous review:
Example implementation: if (!file) {
toast.error("No file selected for upload.");
return { status: "error", fileLocation: "" };
}
const allowedTypes = ["image/jpeg", "image/png"];
const maxSize = 5 * 1024 * 1024; // 5 MB
if (!allowedTypes.includes(file.type)) {
toast.error("Invalid file type. Please upload a JPEG or PNG image.");
return { status: "error", fileLocation: "" };
}
if (file.size > maxSize) {
toast.error("File size exceeds the 5MB limit. Please upload a smaller file.");
return { status: "error", fileLocation: "" };
}This will improve error handling and prevent potential issues with unsupported file types or oversized files. |
||
|
|
||
| try { | ||
| const { size, type } = file; | ||
| const signedUrl = await getUploadUrl({ size, type }); | ||
|
|
||
| if (!signedUrl) { | ||
| toast.error("Failed to upload profile photo. Please try again."); | ||
| return { status: "error", fileLocation: "" }; | ||
| } | ||
|
|
||
| const response = await uploadFile(signedUrl, file); | ||
|
|
||
| const { fileLocation } = response; | ||
|
|
||
| if (!fileLocation) { | ||
| toast.error("Failed to retrieve file location after upload."); | ||
| return { status: "error", fileLocation: "" }; | ||
| } | ||
| await updateUserPhotoUrl({ url: fileLocation }); | ||
| toast.success("Profile photo successfully updated."); | ||
|
|
||
| return { status: "success", fileLocation }; | ||
| } catch (error) { | ||
| if (error instanceof Error) { | ||
| toast.error(error.message); | ||
| } else { | ||
| toast.error("Failed to upload profile photo. Please try again."); | ||
| } | ||
| return { status: "error", fileLocation: "" }; | ||
| } | ||
| }; | ||
|
Comment on lines
+48
to
+56
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance error logging for debugging The error handling in the catch block is good, differentiating between Error instances and unknown errors. To further improve debugging capabilities, consider adding error logging: } catch (error) {
console.error('Image upload failed:', error);
if (error instanceof Error) {
toast.error(error.message);
} else {
toast.error("Failed to upload profile photo. Please try again.");
}
return { status: "error", fileLocation: "" };
}This will help with identifying and resolving issues in production environments while maintaining the user-friendly error messages. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add loading indicator for avatar upload
To improve user experience, consider adding a loading indicator when the avatar is being uploaded. This can be done by utilizing the
profilePhoto.statusstate:<Avatar square src={ profilePhoto.status === "error" || profilePhoto.status === "loading" ? undefined : `${profilePhoto.url}` } alt="Profile photo upload section" - className="h-16 w-16 overflow-hidden rounded-full" + className={`h-16 w-16 overflow-hidden rounded-full ${ + profilePhoto.status === "loading" ? "animate-pulse bg-gray-200" : "" + }`} /> +{profilePhoto.status === "loading" && ( + <div className="absolute inset-0 flex items-center justify-center"> + <span className="loading loading-spinner loading-md"></span> + </div> +)}This will show a pulsing animation and a spinner when the avatar is being uploaded, providing visual feedback to the user.
📝 Committable suggestion