Skip to content

Conversation

qverkk
Copy link

@qverkk qverkk commented Mar 1, 2025

Changes

  • Updated gradle to 8.13
  • Removed a plugin dependency to id("com.coditory.integration-test") version "2.2.4", i have no clue if this is necessary for something, but it looks like a circular dependency
  • This had to be removed as otherwise i wasn't able to update gradle due to build errors

Checklist

  • I have tested that there is no similar pull request already submitted.
    -- There was one from dependabot, i just fixed the code part in order to bump the version
  • I have read contributing.md and applied to the rules.
  • I have updated the documentation if feature was added or changed.
  • I have unit tested code changes and performed a self-review.
  • I have manually tested change locally.

@qverkk qverkk requested a review from a team as a code owner March 1, 2025 18:49
@qverkk qverkk requested a review from pmendelski March 1, 2025 18:49
@xRomZak
Copy link

xRomZak commented Mar 4, 2025

Using Gradle 8.13 + JUnit5 (not JvmTestSuite). Tried to apply a latest plugin version. Will it be resolved by this PR?

An exception occurred applying plugin request [id: 'com.coditory.integration-test', version: '2.2.4']
> Failed to apply plugin 'com.coditory.integration-test'.
   > Could not create domain object 'integration' (JvmTestSuite)

@qverkk
Copy link
Author

qverkk commented Mar 4, 2025

Using Gradle 8.13 + JUnit5 (not JvmTestSuite). Tried to apply a latest plugin version. Will it be resolved by this PR?

An exception occurred applying plugin request [id: 'com.coditory.integration-test', version: '2.2.4']
> Failed to apply plugin 'com.coditory.integration-test'.
   > Could not create domain object 'integration' (JvmTestSuite)

@xRomZak
Hopefully yes, i've tested it on my project and this issue was resolved. We've got to wait for a review from @pmendelski

@@ -1,6 +1,6 @@
plugins {
kotlin("jvm") version "2.1.10"
id("com.coditory.integration-test") version "2.2.4"
// id("com.coditory.integration-test") version "2.2.5"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be removed after receiving a confirmation that this isn't necessary, everything works fine without this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is rather important. Without it most of the tests (that are integration tests) are skipped.

@ogesaku
Copy link
Contributor

ogesaku commented Mar 5, 2025

Hey, thanks for your PR and approaching the gradle upgrade incompatibilities.

The PR required test migration (from integration to test folder) so I created a separate PR #188

The fix is already published in v2.2.5. Please let me know if it solved the problem.

@qverkk
Copy link
Author

qverkk commented Mar 5, 2025

Hey, thanks for your PR and approaching the gradle upgrade incompatibilities.

The PR required test migration (from integration to test folder) so I created a separate PR #188

The fix is already published in v2.2.5. Please let me know if it solved the problem.

Oh right, forgot about that. Thanks for your fix! This PR can be closed 😁

@qverkk qverkk closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants