Improve assertion message for title task #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On the codeschool website it asks students to add their name to the title element
sdknjg8zxq
changed the title
Contributor
|
Good catch! Thanks for the PR. Merging this one in. |
Aru003
added a commit
to Aru003/HelloCodeSchoolProject
that referenced
this pull request
Mar 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the CodeSchool website, the task #5 asks students to add their name as the content for the title element, however the test message asks them to add the text "Code School" instead, which can be confusing.
This change makes the message consistent with the tasks required from the CodeSchool website.