Allow use with non-Page models #43 #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DylannCordel - another refactor (not related to use on snippets, but related to splitting out into mixins) is going in via #71 . Could you take a look at that and see if it will help? You may need to rebase once that is merged in. |
|
Hi @vsalvino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow devs to use this module on non Page Model (Snippet Models). See #43
It would be preferable to
SeoMixinintoSeoMixinForPageandSeoMixinBaseintoSeoMixinForSnippet(or ForModel) but it will introduces a changes which will break backward compatibility.But maybe we could add a
DeprectationWarningto begin to warn users if this PR is accepted ?