-
Notifications
You must be signed in to change notification settings - Fork 2
Add Produce
extension stages
#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: r-branch-produce-stages
Are you sure you want to change the base?
Conversation
…rove test coverage
fix(produce-response): build empty responses and set correlation ID explicitly fix: replace error responses with success in produce response builders to correct test expectations
…nse to simplify response decoding
…re correct behavior
…y to apiKeyNames map
…ordBatches and pass stageLogger as argument to Run for consistency
…m test outputs to simplify fixtures and reduce noise fix: normalize decoder field names and remove duplicate test output line
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
defer client.Close() | ||
|
||
topic := common.TOPIC4_NAME | ||
partitions := random.RandomInts(0, 3, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test Fails Due to Duplicate Partitions
The random.RandomInts(0, 3, 2)
call can return duplicate partition numbers. This causes the test to attempt to produce two different record batches to the same partition within a single Produce request, contradicting the test's goal of testing multiple distinct partitions. This leads to incorrect test logic and potentially undefined test behavior.
Description
This is part 3 of 3 in a stack made with GitButler:
Produce
extension stages #88 👈Produce
assertions #80