[dns] CC-1935: Upgrade Zig to v0.15 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed minimum Zig version from 0.14.0 to 0.15.1 in build.zig.zon files. - Updated build configuration in build.zig files to use `createModule` instead of `addExecutable`. - Updated Codecrafters configuration to reflect the new Zig version. - Adjusted README and config files to require Zig 0.15.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| .root_module = b.createModule(.{ | ||
| .root_source_file = b.path("src/main.zig"), | ||
| .target = b.graph.host, | ||
| }), |
There was a problem hiding this comment.
Bug: Zig 0.15 Migration Loses Build Options
During the Zig 0.15 migration, the addExecutable configuration no longer exposes standard build options for target and optimization. This removes the ability to specify cross-compilation targets (now hardcoded to the host) and control optimization levels via zig build command-line flags, preventing optimized and cross-compiled builds.
Additional Locations (2)
| .root_module = b.createModule(.{ | ||
| .root_source_file = b.path("src/main.zig"), | ||
| .target = b.graph.host, | ||
| }), |
There was a problem hiding this comment.
Bug: Build Configuration Loses Cross-Compilation Flexibility
The build configuration no longer supports cross-compilation or user-defined optimization levels. The target is hardcoded to the host system, and the optimize option has been removed. This prevents users from building for different architectures or specifying optimization flags.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.