-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Use new default-org on internal user for default org decision #3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3905 +/- ##
==========================================
- Coverage 98.66% 98.64% -0.03%
==========================================
Files 828 828
Lines 15071 15065 -6
Branches 4312 4302 -10
==========================================
- Hits 14870 14861 -9
- Misses 193 196 +3
Partials 8 8
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3905 +/- ##
==========================================
- Coverage 98.66% 98.64% -0.03%
==========================================
Files 828 828
Lines 15071 15065 -6
Branches 4312 4310 -2
==========================================
- Hits 14870 14861 -9
- Misses 193 196 +3
Partials 8 8
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3905 +/- ##
==========================================
- Coverage 98.66% 98.64% -0.03%
==========================================
Files 828 828
Lines 15071 15065 -6
Branches 4312 4302 -10
==========================================
- Hits 14870 14861 -9
- Misses 193 196 +3
Partials 8 8
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3905 +/- ##
==========================================
- Coverage 98.66% 98.64% -0.03%
==========================================
Files 828 828
Lines 15071 15065 -6
Branches 4304 4310 +6
==========================================
- Hits 14870 14861 -9
- Misses 193 196 +3
Partials 8 8
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 290 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 290 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niceeeeee, having all this stuff be derived in the API moving forward is a huge win
Main motivation for this is plan page troubles faced by users. A common flow we're trying to fix is: User clicks Learn more on plans page which takes them to our marketing site. They they click Get started from the marketing site, which takes them back to the app, but the default org logic fails and they end up on their personal org instead of the org they started with. We have had several instances of users upgrading the plan of their personal org instead of the desired org from this flow. We made some other improvements to the checkout page in a previous PR, but we also want to get this part fixed as it's likely the primary problem.