Skip to content

feat: Use new default-org on internal user for default org decision #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

spalmurray
Copy link
Contributor

@spalmurray spalmurray commented Jul 2, 2025

Main motivation for this is plan page troubles faced by users. A common flow we're trying to fix is: User clicks Learn more on plans page which takes them to our marketing site. They they click Get started from the marketing site, which takes them back to the app, but the default org logic fails and they end up on their personal org instead of the org they started with. We have had several instances of users upgrading the plan of their personal org instead of the desired org from this flow. We made some other improvements to the checkout page in a previous PR, but we also want to get this part fixed as it's likely the primary problem.

@spalmurray spalmurray changed the title Use new default-org on internal user for default org decision feat: Use new default-org on internal user for default org decision Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (4ec0a46) to head (cfdfa59).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   98.66%   98.64%   -0.03%     
==========================================
  Files         828      828              
  Lines       15071    15065       -6     
  Branches     4312     4302      -10     
==========================================
- Hits        14870    14861       -9     
- Misses        193      196       +3     
  Partials        8        8              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
src/services/user/useInternalUser.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.17% <ø> (ø)
Services 99.32% <ø> (-0.04%) ⬇️
Shared 99.12% <ø> (ø)
UI 99.01% <ø> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec0a46...cfdfa59. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (4ec0a46) to head (cfdfa59).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   98.66%   98.64%   -0.03%     
==========================================
  Files         828      828              
  Lines       15071    15065       -6     
  Branches     4312     4310       -2     
==========================================
- Hits        14870    14861       -9     
- Misses        193      196       +3     
  Partials        8        8              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
src/services/user/useInternalUser.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.17% <ø> (ø)
Services 99.32% <ø> (-0.04%) ⬇️
Shared 99.12% <ø> (ø)
UI 99.01% <ø> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec0a46...cfdfa59. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov-public-qa bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (4ec0a46) to head (cfdfa59).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   98.66%   98.64%   -0.03%     
==========================================
  Files         828      828              
  Lines       15071    15065       -6     
  Branches     4312     4302      -10     
==========================================
- Hits        14870    14861       -9     
- Misses        193      196       +3     
  Partials        8        8              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
src/services/user/useInternalUser.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.17% <ø> (ø)
Services 99.32% <ø> (-0.04%) ⬇️
Shared 99.12% <ø> (ø)
UI 99.01% <ø> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec0a46...cfdfa59. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   98.66%   98.64%   -0.03%     
==========================================
  Files         828      828              
  Lines       15071    15065       -6     
  Branches     4304     4310       +6     
==========================================
- Hits        14870    14861       -9     
- Misses        193      196       +3     
  Partials        8        8              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
src/services/user/useInternalUser.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.17% <ø> (ø)
Services 99.32% <ø> (-0.04%) ⬇️
Shared 99.12% <ø> (ø)
UI 99.01% <ø> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec0a46...cfdfa59. Read the comment docs.

@spalmurray spalmurray marked this pull request as ready for review July 2, 2025 15:03
@codecov-staging
Copy link

codecov-staging bot commented Jul 2, 2025

Bundle Report

Changes will decrease total bundle size by 290 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.23MB -95 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.31MB -195 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -195 bytes 639.26kB -0.03%

Files in assets/index.*.js:

  • ./src/services/user/useInternalUser.ts → Total Size: 1.16kB

  • ./src/App.tsx → Total Size: 8.47kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -95 bytes 716.72kB -0.01%

Files in assets/index-legacy.*.js:

  • ./src/services/user/useInternalUser.ts → Total Size: 1.17kB

  • ./src/App.tsx → Total Size: 8.62kB

Copy link

codecov bot commented Jul 2, 2025

Bundle Report

Changes will decrease total bundle size by 290 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.23MB -95 bytes (-0.0%) ⬇️
gazebo-production-esm 6.31MB -195 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -195 bytes 639.26kB -0.03%

Files in assets/index.*.js:

  • ./src/services/user/useInternalUser.ts → Total Size: 1.16kB

  • ./src/App.tsx → Total Size: 8.47kB

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -95 bytes 716.72kB -0.01%

Files in assets/index-legacy.*.js:

  • ./src/services/user/useInternalUser.ts → Total Size: 1.17kB

  • ./src/App.tsx → Total Size: 8.62kB

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cfdfa59 Wed, 02 Jul 2025 17:29:55 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeeee, having all this stuff be derived in the API moving forward is a huge win

@spalmurray spalmurray added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit 07ae444 Jul 2, 2025
60 of 64 checks passed
@spalmurray spalmurray deleted the spalmurray/use-internal-user-default-org branch July 2, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants