Skip to content

fix: Safari coverage chart overflowing #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

fix: Safari coverage chart overflowing #3873

merged 2 commits into from
May 26, 2025

Conversation

spalmurray
Copy link
Contributor

Fixes the coverage chart overflowing its container on safari.

@spalmurray spalmurray changed the title fix: Safari coverage chart overflowwing fix: Safari coverage chart overflowing May 23, 2025
@spalmurray spalmurray marked this pull request as ready for review May 23, 2025 17:44
@codecov Codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 31.64kB (0.25%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.23MB 15.62kB (0.25%) ⬆️
gazebo-production-esm 6.31MB 16.03kB (0.25%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -1 bytes 127.33kB -0.0%
assets/index.*.js -8 bytes 89.2kB -0.01%
assets/vendor_recharts.*.js 13.53kB 549.82kB 2.52%
assets/vendor_sentry.*.js 2.53kB 317.7kB 0.8%
assets/index.*.css -39 bytes 101.42kB -0.04%
assets/vendor_react_router.*.js 18 bytes 35.31kB 0.05%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/CoverageTab/OverviewTab/subroute/CoverageChart/CoverageChart.tsx → Total Size: 3.99kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -40 bytes 716.79kB -0.01%
assets/index-legacy.*.js -1 bytes 115.89kB -0.0%
assets/index-legacy.*.js -8 bytes 83.95kB -0.01%
assets/vendor_recharts-legacy.*.js 13.39kB 534.59kB 2.57%
assets/vendor_sentry-legacy.*.js 2.26kB 306.96kB 0.74%
assets/vendor_react_router-legacy.*.js 19 bytes 30.24kB 0.06%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/CoverageTab/OverviewTab/subroute/CoverageChart/CoverageChart.tsx → Total Size: 3.99kB

@codecov-staging
Copy link

codecov-staging bot commented May 23, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 31.64kB (0.25%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.23MB 15.62kB (0.25%) ⬆️
gazebo-staging-esm 6.31MB 16.03kB (0.25%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -1 bytes 127.33kB -0.0%
assets/index.*.js -8 bytes 89.2kB -0.01%
assets/vendor_recharts.*.js 13.53kB 549.82kB 2.52%
assets/vendor_sentry.*.js 2.53kB 317.7kB 0.8%
assets/index.*.css -39 bytes 101.42kB -0.04%
assets/vendor_react_router.*.js 18 bytes 35.31kB 0.05%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/CoverageTab/OverviewTab/subroute/CoverageChart/CoverageChart.tsx → Total Size: 3.99kB
view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -8 bytes 83.95kB -0.01%
assets/index-legacy.*.js -1 bytes 115.89kB -0.0%
assets/index-legacy.*.js -40 bytes 716.79kB -0.01%
assets/vendor_recharts-legacy.*.js 13.39kB 534.59kB 2.57%
assets/vendor_sentry-legacy.*.js 2.26kB 306.96kB 0.74%
assets/vendor_react_router-legacy.*.js 19 bytes 30.24kB 0.06%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/CoverageTab/OverviewTab/subroute/CoverageChart/CoverageChart.tsx → Total Size: 3.99kB

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (ca0515b) to head (201fcf1).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3873   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4296     4296           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.66% <ø> (ø)
src/ui/Chart/Chart.tsx 97.22% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0515b...201fcf1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov Codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (ca0515b) to head (92435f1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3873   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4296     4296           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.66% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0515b...92435f1. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (ca0515b) to head (92435f1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3873   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4296     4296           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.66% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0515b...92435f1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-notifications
Copy link

codecov-notifications bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3873   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4296     4296           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.66% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0515b...92435f1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 23, 2025 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
201fcf1 Fri, 23 May 2025 17:49:54 GMT Expired Expired
92435f1 Mon, 26 May 2025 14:27:31 GMT Cloud Enterprise

@spalmurray spalmurray added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 9ed36d8 May 26, 2025
64 checks passed
@spalmurray spalmurray deleted the spalmurray/fix-safari-coverage-chart branch May 26, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-sentry joseph-sentry joseph-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalmurray @codecov-releaser @joseph-sentry