fix: Handle segments ProviderError #3852

suejung-sentry · 2025-04-23T22:02:33Z

Handle when segments returns ProviderError or UnknownPath here.

codecov · 2025-04-23T22:05:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (8267885) to head (db32dfe).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3852   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15006    15031   +25     
  Branches     4293     4297    +4     
=======================================
+ Hits        14815    14840   +25     
  Misses        184      184           
  Partials        7        7

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`98.14% <100.00%> (+0.52%)`	⬆️
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`98.18% <100.00%> (+0.50%)`	⬆️
src/services/comparison/constants.ts	`100.00% <ø> (ø)`
...ommitAndParent/useComparisonForCommitAndParent.tsx	`100.00% <ø> (ø)`
src/services/navigation/useStaticNavLinks.ts	`98.86% <100.00%> (+0.01%)`	⬆️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.28% <100.00%> (+<0.01%)`	⬆️
Services	`99.35% <100.00%> (+<0.01%)`	⬆️
Shared	`99.11% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8267885...db32dfe. Read the comment docs.

codecov-qa · 2025-04-23T22:05:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (8267885) to head (db32dfe).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3852   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15006    15031   +25     
  Branches     4293     4297    +4     
=======================================
+ Hits        14815    14840   +25     
  Misses        184      184           
  Partials        7        7

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`98.14% <100.00%> (+0.52%)`	⬆️
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`98.18% <100.00%> (+0.50%)`	⬆️
src/services/comparison/constants.ts	`100.00% <ø> (ø)`
...ommitAndParent/useComparisonForCommitAndParent.tsx	`100.00% <ø> (ø)`
src/services/navigation/useStaticNavLinks.ts	`98.86% <100.00%> (+0.01%)`	⬆️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.28% <100.00%> (+<0.01%)`	⬆️
Services	`99.35% <100.00%> (+<0.01%)`	⬆️
Shared	`99.11% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8267885...db32dfe. Read the comment docs.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-public-qa · 2025-04-23T22:05:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (8267885) to head (db32dfe).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3852   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15006    15031   +25     
  Branches     4285     4297   +12     
=======================================
+ Hits        14815    14840   +25     
  Misses        184      184           
  Partials        7        7

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`98.14% <100.00%> (+0.52%)`	⬆️
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`98.18% <100.00%> (+0.50%)`	⬆️
src/services/comparison/constants.ts	`100.00% <ø> (ø)`
...ommitAndParent/useComparisonForCommitAndParent.tsx	`100.00% <ø> (ø)`
src/services/navigation/useStaticNavLinks.ts	`98.86% <100.00%> (+0.01%)`	⬆️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.28% <100.00%> (+<0.01%)`	⬆️
Services	`99.35% <100.00%> (+<0.01%)`	⬆️
Shared	`99.11% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8267885...db32dfe. Read the comment docs.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-staging · 2025-04-23T22:05:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3852   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15006    15031   +25     
  Branches     4285     4297   +12     
=======================================
+ Hits        14815    14840   +25     
  Misses        184      184           
  Partials        7        7

Files with missing lines	Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`98.14% <100.00%> (+0.52%)`	⬆️
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`98.18% <100.00%> (+0.50%)`	⬆️
src/services/comparison/constants.ts	`100.00% <ø> (ø)`
...ommitAndParent/useComparisonForCommitAndParent.tsx	`100.00% <ø> (ø)`
src/services/navigation/useStaticNavLinks.ts	`98.86% <100.00%> (+0.01%)`	⬆️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.28% <100.00%> (+<0.01%)`	⬆️
Services	`99.35% <100.00%> (+<0.01%)`	⬆️
Shared	`99.11% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8267885...db32dfe. Read the comment docs.

codecov · 2025-04-24T00:43:08Z

Bundle Report

Changes will increase total bundle size by 4.71kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.21MB	2.29kB (0.04%) ⬆️
gazebo-production-esm	6.29MB	2.42kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	118 bytes	716.84kB	0.02%
`assets/index-legacy.*.js`	2.17kB	115.89kB	1.91%

Files in assets/index-legacy.*.js:

./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.99kB

Files in assets/index-legacy.*.js:

./src/services/comparison/constants.ts → Total Size: 1.03kB
./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.04kB
./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.06kB
./src/services/comparison/useComparisonForCommitAndParent/useComparisonForCommitAndParent.tsx → Total Size: 4.22kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	2.3kB	127.33kB	1.84%
`assets/index.*.js`	118 bytes	639.45kB	0.02%

Files in assets/index.*.js:

./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.06kB
./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.04kB
./src/services/comparison/useComparisonForCommitAndParent/useComparisonForCommitAndParent.tsx → Total Size: 4.22kB
./src/services/comparison/constants.ts → Total Size: 1.03kB

Files in assets/index.*.js:

./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.99kB

seer-by-sentry · 2025-04-24T00:43:10Z

✅ Sentry found no issues in your recent changes ✅

codecov-staging · 2025-04-24T00:43:13Z

Bundle Report

Changes will increase total bundle size by 4.71kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system	6.21MB	2.29kB (0.04%) ⬆️
gazebo-staging-esm	6.29MB	2.42kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	2.17kB	115.89kB	1.91%
`assets/index-legacy.*.js`	118 bytes	716.84kB	0.02%

Files in assets/index-legacy.*.js:

./src/services/comparison/constants.ts → Total Size: 1.03kB
./src/services/comparison/useComparisonForCommitAndParent/useComparisonForCommitAndParent.tsx → Total Size: 4.22kB
./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.04kB
./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.06kB

Files in assets/index-legacy.*.js:

./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.99kB

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	2.3kB	127.33kB	1.84%
`assets/index.*.js`	118 bytes	639.45kB	0.02%

Files in assets/index.*.js:

./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.06kB
./src/services/comparison/useComparisonForCommitAndParent/useComparisonForCommitAndParent.tsx → Total Size: 4.22kB
./src/services/comparison/constants.ts → Total Size: 1.03kB
./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 6.04kB

Files in assets/index.*.js:

./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.99kB

codecov-releaser · 2025-04-24T00:46:12Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`6731c18`	Thu, 24 Apr 2025 00:46:12 GMT	Expired	Expired
`d89167c`	Thu, 24 Apr 2025 01:05:30 GMT	Expired	Expired
`5c887ba`	Thu, 24 Apr 2025 20:59:34 GMT	Expired	Expired
`db32dfe`	Fri, 25 Apr 2025 17:07:43 GMT	Cloud	Enterprise

nsdeschenes · 2025-04-24T11:07:25Z

...mitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx

-  return <DiffRenderer impactedFile={comparisonData.impactedFile} path={path} />
+  // since above we've handled when segments is of one of the other union types,
+  // we can safely assert that it's of type SegmentComparisons now
+  const impactedFile = comparisonData.impactedFile as ImpactedFileType


Do you need to assert this? TS should automatically narrow it. If it's not doing that, a case may be missed in the conditional 🤔

Hm yeah I think the problem was that the type narrowing only applied to the top-level variable, but didn't carry through to the nested property access. I wasn't able to get it to infer the narrowed type in that deeper context, so did that uglier workaround.
I pulled out the value into a separate variable, and that seems to have allowed TypeScript to apply the narrowing correctly, so we can go with this version!

Let's goooo

nsdeschenes · 2025-04-24T11:08:06Z

...mitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx

-  return <DiffRenderer impactedFile={comparisonData.impactedFile} path={path} />
+  // since above we've handled when segments is of one of the other union types,
+  // we can safely assert that it's of type SegmentComparisons now
+  const impactedFile = comparisonData.impactedFile as ImpactedFileType


Same thing down here, TS narrowing should make it so we don't need to cast types

thanks yeah same as above ^

nsdeschenes · 2025-04-24T11:09:20Z

...mitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx

+    !comparisonData?.impactedFile ||
+    !path ||
+    hadErrorFetchingFileFromProvider
+  ) {
    return <ErrorDisplayMessage />


Are we able to display a more helpful error message for these new errors that we're detecting? To better inform the user what's going on.

Oh yeah sure good call. The existing one was appropriate for the ProviderError and I added one for the UnknownPath error

fix: Handle segments ProviderError

4e38db9

suejung-sentry force-pushed the sshin/1317 branch 2 times, most recently from acf7d29 to 6731c18 Compare April 24, 2025 00:40

fix tests

d89167c

suejung-sentry force-pushed the sshin/1317 branch from 6731c18 to d89167c Compare April 24, 2025 00:59

nsdeschenes reviewed Apr 24, 2025

View reviewed changes

suejung-sentry added 2 commits April 24, 2025 13:53

Merge remote-tracking branch 'origin/main' into sshin/1317

5c887ba

incorporate pr comments

db32dfe

nsdeschenes approved these changes Apr 28, 2025

View reviewed changes

spalmurray approved these changes Apr 28, 2025

View reviewed changes

suejung-sentry added this pull request to the merge queue Apr 28, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2025

suejung-sentry added this pull request to the merge queue Apr 28, 2025

Merged via the queue into main with commit ebeb86f Apr 28, 2025
64 checks passed

suejung-sentry deleted the sshin/1317 branch April 28, 2025 17:06

fix: Handle segments ProviderError #3852

fix: Handle segments ProviderError #3852

Uh oh!

Conversation

suejung-sentry commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-qa bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-public-qa bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-staging bot commented Apr 23, 2025 • edited by codecov-notifications bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

Uh oh!

seer-by-sentry bot commented Apr 24, 2025

✅ Sentry found no issues in your recent changes ✅

Uh oh!

codecov-staging bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

Uh oh!

codecov-releaser commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy preview for gazebo ready!

Uh oh!

nsdeschenes Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

suejung-sentry Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

nsdeschenes Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

nsdeschenes Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

suejung-sentry Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

nsdeschenes Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

suejung-sentry Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

suejung-sentry commented Apr 23, 2025 •

edited

Loading

codecov bot commented Apr 23, 2025 •

edited

Loading

codecov-qa bot commented Apr 23, 2025 •

edited

Loading

codecov-public-qa bot commented Apr 23, 2025 •

edited

Loading

codecov-staging bot commented Apr 23, 2025 •

edited by codecov-notifications bot

Loading

codecov bot commented Apr 24, 2025 •

edited

Loading

codecov-staging bot commented Apr 24, 2025 •

edited

Loading

codecov-releaser commented Apr 24, 2025 •

edited

Loading