Skip to content

ref: Migrate useGenerateUserToken to TSQ V5 #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useGenerateUserToken over to TSQ V5, and updates it's usage throughout the app.

Ticket: codecov/engineering-team#3167

Notable Changes

  • Migrate useGenerateUserToken over to TSQ V5
  • Update usage in CreateTokenModal
  • Update tests

@codecov-staging
Copy link

codecov-staging bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/access/useGenerateUserToken.ts 90.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         826      826           
  Lines       14867    14869    +2     
  Branches     4229     4229           
=======================================
+ Hits        14695    14697    +2     
  Misses        166      166           
  Partials        6        6           
Files with missing lines Coverage Δ
...s/AccountSettings/tabs/Access/CreateTokenModal.jsx 100.00% <100.00%> (ø)
src/services/access/useGenerateUserToken.ts 93.33% <90.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <100.00%> (ø)
Services 99.24% <90.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d59ae...3990e9a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (77d59ae) to head (3990e9a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/access/useGenerateUserToken.ts 90.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         826      826           
  Lines       14867    14869    +2     
  Branches     4221     4221           
=======================================
+ Hits        14695    14697    +2     
  Misses        166      166           
  Partials        6        6           
Files with missing lines Coverage Δ
...s/AccountSettings/tabs/Access/CreateTokenModal.jsx 100.00% <100.00%> (ø)
src/services/access/useGenerateUserToken.ts 93.33% <90.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <100.00%> (ø)
Services 99.24% <90.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d59ae...3990e9a. Read the comment docs.

Copy link

codecov-public-qa bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (77d59ae) to head (3990e9a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/access/useGenerateUserToken.ts 90.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         826      826           
  Lines       14867    14869    +2     
  Branches     4229     4221    -8     
=======================================
+ Hits        14695    14697    +2     
  Misses        166      166           
  Partials        6        6           
Files with missing lines Coverage Δ
...s/AccountSettings/tabs/Access/CreateTokenModal.jsx 100.00% <100.00%> (ø)
src/services/access/useGenerateUserToken.ts 93.33% <90.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <100.00%> (ø)
Services 99.24% <90.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d59ae...3990e9a. Read the comment docs.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (77d59ae) to head (3990e9a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/access/useGenerateUserToken.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         826      826           
  Lines       14867    14869    +2     
  Branches     4229     4221    -8     
=======================================
+ Hits        14695    14697    +2     
  Misses        166      166           
  Partials        6        6           
Files with missing lines Coverage Δ
...s/AccountSettings/tabs/Access/CreateTokenModal.jsx 100.00% <100.00%> (ø)
src/services/access/useGenerateUserToken.ts 93.33% <90.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <100.00%> (ø)
Services 99.24% <90.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d59ae...3990e9a. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 13, 2025

Bundle Report

Changes will decrease total bundle size by 96 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-esm 6.31MB -44 bytes (-0.0%) ⬇️
gazebo-staging-system 6.26MB -52 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -52 bytes 9.73kB -0.53%

Files in assets/index-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/Access/CreateTokenModal.jsx → Total Size: 3.04kB

  • ./src/services/access/useGenerateUserToken.ts → Total Size: 1.47kB

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -44 bytes 9.83kB -0.45%

Files in assets/index.*.js:

  • ./src/services/access/useGenerateUserToken.ts → Total Size: 1.47kB

  • ./src/pages/AccountSettings/tabs/Access/CreateTokenModal.jsx → Total Size: 3.04kB

Copy link

codecov bot commented Feb 13, 2025

Bundle Report

Changes will decrease total bundle size by 96 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.26MB -52 bytes (-0.0%) ⬇️
gazebo-production-esm 6.31MB -44 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -44 bytes 9.83kB -0.45%

Files in assets/index.*.js:

  • ./src/services/access/useGenerateUserToken.ts → Total Size: 1.47kB

  • ./src/pages/AccountSettings/tabs/Access/CreateTokenModal.jsx → Total Size: 3.04kB

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -52 bytes 9.73kB -0.53%

Files in assets/index-legacy.*.js:

  • ./src/services/access/useGenerateUserToken.ts → Total Size: 1.47kB

  • ./src/pages/AccountSettings/tabs/Access/CreateTokenModal.jsx → Total Size: 3.04kB

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
3990e9a Thu, 13 Feb 2025 15:12:55 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 95c655d Feb 13, 2025
54 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3167-ref-useGenerateUserToken-to-tsqv5 branch February 13, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants